From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0FD8549BBE for ; Fri, 3 May 2024 23:38:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44BD068D6E4; Sat, 4 May 2024 02:38:10 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B8BB68D68E for ; Sat, 4 May 2024 02:38:02 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3B480C0004 for ; Fri, 3 May 2024 23:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714779482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jrDcbDZDL6o5jBbM0Q0GRJdtt3k5zj/VE9uhWbwCGuo=; b=SpRlJ77T40pwsXggGr0BWUYj4DmZdh6z3GXcldtwz53seTbFi50v1ARYO4Luz12WJa2VCT 7OhFUM0Q6XJYd4tuzjgEM7QHBNrPnuCDyRp2pCGqFy2+tG1Um4GvA1AvzirmMIDSDAiA7J D1SvBQX/Vn6NdZ6iDAJjX7N0Sp7qPqUTrVOgez3ATf2r2Q7ZbTLaGKR+MwwcquLJJ0eFZs ivd/ay9KIEw6uJzZkuYqbY9o64bbJwm71jkIC79uZ1QCEXBW2KnvjGxbKRndjcgwDyhP1Z 4Qe7/2N1kzD8G+poTk+gD6//8Jd3a3I2eaT8UQd9uppssQqw4RTxD4ancXDxkw== Date: Sat, 4 May 2024 01:38:01 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240503233801.GO6420@pb2> References: <20240503215502.1509887-1-michael@niedermayer.cc> <20240503215502.1509887-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4053451340186536655==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4053451340186536655== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KSdMoKyyAiKMwDCS" Content-Disposition: inline --KSdMoKyyAiKMwDCS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 04, 2024 at 12:21:03AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1596607 Uninitialized scalar variable > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dovi_rpuenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c > > index 7e0292533bd..c5e452957b5 100644 > > --- a/libavcodec/dovi_rpuenc.c > > +++ b/libavcodec/dovi_rpuenc.c > > @@ -57,7 +57,7 @@ int ff_dovi_configure(DOVIContext *s, AVCodecContext = *avctx) > > AVDOVIDecoderConfigurationRecord *cfg; > > const AVDOVIRpuDataHeader *hdr =3D NULL; > > const AVFrameSideData *sd; > > - int dv_profile, dv_level, bl_compat_id; > > + int dv_profile, dv_level, bl_compat_id =3D -1; > > size_t cfg_size; > > uint64_t pps; > > =20 >=20 > This is unnecessary, as the dv_profile switch is exhaustive (i.e. the > default case is never taken); but if you do this, then you can also > remove the other "bl_compat_id =3D -1" assignments (which conveys that > everything is treated as invalid unless we found it to have a valid > compatibility id). i see case AV_CODEC_ID_H264: dv_profile =3D 9; break; the dv_profile switch only contains 0 4 7 5 10 8 no 9 what am i missing ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire --KSdMoKyyAiKMwDCS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjV1TgAKCRBhHseHBAsP q0zwAKCXK/Ug4jn2xbljwdvwMWexelSIuwCdFBcGECxppfSaEIYqSile6RuvUnc= =xF5d -----END PGP SIGNATURE----- --KSdMoKyyAiKMwDCS-- --===============4053451340186536655== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4053451340186536655==--