From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CDBB1490FA for ; Fri, 3 May 2024 23:13:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B704B68D6B1; Sat, 4 May 2024 02:13:54 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C0DC68D63A for ; Sat, 4 May 2024 02:13:47 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C1F21240007 for ; Fri, 3 May 2024 23:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714778026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SRaPOjbtj/z5T9WSD6OVgs5Q+kn+xeiw2s7ghVgVj+c=; b=KvhxhjlzADd/CS65MssdHoEYrFjqgnZOmYfYYmMtfBZU2fsv1edVh1S/SkF+dmQsiiRAeh gS4OA7nFGL+j/N8T8eOGcdKchP5JHLQ9t8Yuq6Ry55GtR9t7MkwEMFyv+XdbWOByIYTgl/ NQqI1HyPq6Y0Hl7NVq1X2w1WkL2gBl/ua5eyY0zfio82BYAq6XEM7w8N4R0E4GUZrB5VTa wsc3SNztpXSMjEGIaWW1xH06OOjdOV/QLqwykh4RsOGwDMpmfLN69pj9vDCVtXacq7WO/K TmYZARVQQPYSmwrU6K3O2ne9Mu5XIZHokplpdJAVi/d0RIaCaXH9hdoeEERTsQ== Date: Sat, 4 May 2024 01:13:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240503231346.GM6420@pb2> References: <20240503163623.376990-1-derek.buitenhuis@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240503163623.376990-1-derek.buitenhuis@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Avoid overflow when calculating DAR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3117223610847855196==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3117223610847855196== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yJgbVKV6zfBv8JLg" Content-Disposition: inline --yJgbVKV6zfBv8JLg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 03, 2024 at 05:36:23PM +0100, Derek Buitenhuis wrote: > Both the codecpar's width and height, and the SAR num and den are > ints, which can overflow. Cast to int64_t, which is what av_reduce > takes. >=20 > Without this, occasionally, display_aspect_ratio can be negative in > ffprobe's -show_stream output. >=20 > Signed-off-by: Derek Buitenhuis > --- > fftools/ffprobe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --yJgbVKV6zfBv8JLg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjVvpgAKCRBhHseHBAsP q46FAKCL7tHTmDNI5SsvdREIe+TWpzOb8QCfdgx0RlejGc8spT+bmqo3VY+yHFA= =k6J7 -----END PGP SIGNATURE----- --yJgbVKV6zfBv8JLg-- --===============3117223610847855196== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3117223610847855196==--