From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 761244A610 for ; Thu, 2 May 2024 23:27:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A0FA68D88D; Fri, 3 May 2024 02:27:44 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9178C68D5D9 for ; Fri, 3 May 2024 02:27:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B6AA11BF203 for ; Thu, 2 May 2024 23:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714692456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BJr/HC0ieK7Tc5Tye0N0ZOlX1OGBXYjhIb1SWd93pn4=; b=VgAeiZ3KtVa7AMiDiRgBXFXYHYxPoaFxltE9LsfgwEWgJqZ8Nm68uOn0ANmWlGjZGXzgKm ejyQfQngM5aQ/eZYw08ZAaHDAimwqPW11ywIWNtpcvaDVajK59YxCeaBxZwoNjosGBPzz1 AbYxEahOYsOCxDoh5/tO+QnAvzBqHOvrZU5YId8bk6ec4tv6wCHnQcNYAo7qiJsgMqZaFo BExya8xwiXDxVYA6rKqUn+QMVubqGu2utctlDRho4VKt8PqA+ei3K2aLXN6SrikGPF1rZB r86owTKvNvlNbzdjSbEvsQadD4BADXVu9rlQLDkanfaf9A9Z2hg9sYqZoDLByg== Date: Fri, 3 May 2024 01:27:35 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240502232735.GK6420@pb2> References: <20240430231926.2506728-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3250385624204971572==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3250385624204971572== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wyh/DUlk4H7IViVC" Content-Disposition: inline --wyh/DUlk4H7IViVC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Thu, May 02, 2024 at 11:23:13PM +0200, Marton Balint wrote: [...] > surely some users depend on it behaving in a certain > way... who ? I dont think you should assume something without evidence especially for framecrc, which isnt that usefull except for testing the output is changed vs identical. This patch (or a variation of it) improves this very usecase Also whats your oppinion Marton ? should we test side data or not test side data. In teh tests in FFmpeg (FATE) ? And framecrc is what tests the produced AVPackets I think james replied to the rest already thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --wyh/DUlk4H7IViVC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjQhZAAKCRBhHseHBAsP q+JJAJ9ns6zP7DDB2F5dUfNgVDmhj3Dd8gCgkPHTU/eLmdxu76U0NJjchuRowCg= =Kp7S -----END PGP SIGNATURE----- --wyh/DUlk4H7IViVC-- --===============3250385624204971572== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3250385624204971572==--