From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8EB964A60C for ; Thu, 2 May 2024 22:12:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A00B668D897; Fri, 3 May 2024 01:12:25 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A5D8368D812 for ; Fri, 3 May 2024 01:12:19 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0580F1C0002 for ; Thu, 2 May 2024 22:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714687939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XnnbcuyPHdvJKakwV71RH0K1vWbjqfEDDj7PJO6WmEg=; b=Uk2Xxskq3RwzG7gosAY44vlMQQOR6n7pwKOb5u3nuW1QqNqVGw3OnI+H3m6SJV2TD40Chy UXbetBIgIgsWlBA8o4y9CS6pZYdZV81iL9zvCxJWxxe2y1PCXKuq4zb6614QxESkz1BSYB NAYCn9vpDaMdI6z0koq8Ujs6lEmIvEFCB7I0GScOeUO1tLRZGp/XFAXMp/0L5LAf2QFAKh HWjwXv0YfZENY/okP+TkVEFvb3qCTCThTioCNQbhLeMc+pjfvFzXpUt2ICxfqrZ0uFamLL k/iGrVRi0Ceu82TUCiIbOMgsUeyKsvlcDT3ONqlK/ry9LmOibW0mWi4pHNW94g== Date: Fri, 3 May 2024 00:12:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240502221218.GJ6420@pb2> References: <20240502004150.3627661-1-michael@niedermayer.cc> <8baf5a87-e2d9-4c4e-9cbe-6d86471bd1ce@gmail.com> MIME-Version: 1.0 In-Reply-To: <8baf5a87-e2d9-4c4e-9cbe-6d86471bd1ce@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/av1dec: bit_depth cannot be another values than 8, 10, 12 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4514679721538234377==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4514679721538234377== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zS7IJaqgGUiIFzJd" Content-Disposition: inline --zS7IJaqgGUiIFzJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 01, 2024 at 09:56:53PM -0300, James Almer wrote: > On 5/1/2024 9:41 PM, Michael Niedermayer wrote: > > Fixes: CID1544265 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/av1dec.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > >=20 > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > > index 79a30a114da..4f9222cca27 100644 > > --- a/libavcodec/av1dec.c > > +++ b/libavcodec/av1dec.c > > @@ -493,7 +493,7 @@ static enum AVPixelFormat get_sw_pixel_format(void = *logctx, > > else if (bit_depth =3D=3D 12) > > pix_fmt =3D AV_PIX_FMT_YUV444P12; > > else > > - av_log(logctx, AV_LOG_WARNING, "Unknown AV1 pixel form= at.\n"); > > + av_assert0(0); > > } else if (seq->color_config.subsampling_x =3D=3D 1 && > > seq->color_config.subsampling_y =3D=3D 0) { > > if (bit_depth =3D=3D 8) > > @@ -503,7 +503,7 @@ static enum AVPixelFormat get_sw_pixel_format(void = *logctx, > > else if (bit_depth =3D=3D 12) > > pix_fmt =3D AV_PIX_FMT_YUV422P12; > > else > > - av_log(logctx, AV_LOG_WARNING, "Unknown AV1 pixel form= at.\n"); > > + av_assert0(0); > > } else if (seq->color_config.subsampling_x =3D=3D 1 && > > seq->color_config.subsampling_y =3D=3D 1) { > > if (bit_depth =3D=3D 8) > > @@ -513,7 +513,7 @@ static enum AVPixelFormat get_sw_pixel_format(void = *logctx, > > else if (bit_depth =3D=3D 12) > > pix_fmt =3D AV_PIX_FMT_YUV420P12; > > else > > - av_log(logctx, AV_LOG_WARNING, "Unknown AV1 pixel form= at.\n"); > > + av_assert0(0); > > } > > } else { > > if (bit_depth =3D=3D 8) > > @@ -523,7 +523,7 @@ static enum AVPixelFormat get_sw_pixel_format(void = *logctx, > > else if (bit_depth =3D=3D 12) > > pix_fmt =3D AV_PIX_FMT_GRAY12; > > else > > - av_log(logctx, AV_LOG_WARNING, "Unknown AV1 pixel format.\= n"); > > + av_assert0(0); > > } > > return pix_fmt; >=20 > LGTM. will apply >=20 > Can you change bit_depth into an int while at it? no reason for it to be > uint8_t as a scalar. ok, but its unrelated thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --zS7IJaqgGUiIFzJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjQPwgAKCRBhHseHBAsP q1FjAJ9Ti6iUL0VWzS3MLz1lkX4Bj9QHewCeN1C1BU3KKUWp6RMv+av2Y7YQS1Q= =X9Mi -----END PGP SIGNATURE----- --zS7IJaqgGUiIFzJd-- --===============4514679721538234377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4514679721538234377==--