From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 67C064A56E for ; Thu, 2 May 2024 10:12:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64CC368D7C4; Thu, 2 May 2024 13:12:27 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE47668D7BC for ; Thu, 2 May 2024 13:12:20 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1714644740; bh=vh6bshfUV1fDPlO58udhTs4t1xok534xLDHpZ0c8c24=; h=Date:From:To:Subject:In-Reply-To:References:From; b=OmIH/lKwcip80Gm05VWcDVYHjH4bnZTPQlPIMgbi9HG+s/6bCyIQDK0Y6qT6hIEDM 9fbkq0/ueLntfZ08hgVw4NUaGRuiUnVwivNaGq+I3Ij3qEPaQsQPccqBWUdMxRydg+ GcKwT1YZ/aXAxX9rVo8KDJYG+KtHiBbnbb/doVHU= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 7E91840356 for ; Thu, 2 May 2024 12:12:20 +0200 (CEST) Date: Thu, 2 May 2024 12:12:20 +0200 Message-ID: <20240502121220.GE10830@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240424110257.38715-1-ffmpeg@haasn.xyz> References: <20240424110257.38715-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 0/5] replace scale2ref by scale=rw:rh X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 24 Apr 2024 12:51:55 +0200 Niklas Haas wrote: > As discussed in my previous series for fixing scale2ref[1], this filter > is fundamentally broken, and the only real fix would be to switch to > activate(), or ideally FFFrameSync. > > [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-March/323382.html > > The main thing making this difficult is the fact that scale2ref also > wants to output ref frames to its secondary output, which FFFrameSync > does not support, and which is ultimately at least part of the root > cause of trac #10795. > > Since this is in principle completely unnecessary (users can just > 'split' the ref input and have it be consumed by vf_scale), and to make > the design of this filter a bit more robust and maintainable, switch to > an approach where vf_scale itself gains the ability to reference > a secondary input stream, using the "ref_*" series of variables. > > This makes the current [i][ri]scale2ref[o][ro] equivalent to the only > slightly more verbose [ri]split[t][ro]; [i][t]scale=rw:rh[o]. (And > conversely, it is no longer necessary to use nullsink to consume an > unused [ro]) > > Incidentally, I think it would be nice if lavfi could *automatically* > split filter links referenced multiple times, so we could just write > e.g. [i][ri]scale=rw:rh[o]; [ri][o]overlay[out] and have it work. Maybe > I'll try getting that to work, next. > > Either way, after the deprecation period has elapsed, we can delete > scale2ref from the codebase in order to make vf_scale.c IMHO > significantly simpler versus the status quo. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". Will merge in around 24h if there is no objection, as this is fixing a bug marked important. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".