From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E477E4A567 for ; Thu, 2 May 2024 01:28:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C65FF68D77B; Thu, 2 May 2024 04:28:43 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 68F6F68D6CA for ; Thu, 2 May 2024 04:28:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C7983C0005 for ; Thu, 2 May 2024 01:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714613316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DPXp5KLsVZAOp/csXIDLxaR1TMORyifazjVSojHzbik=; b=lSgZNuFuuMU5yZbQpGF29D2FTabW5KsGPqtiHT/2Kq9kd51uz+3QXCW+SKrNybxzM5nalL COFNl+jcQdC636emwP54jpEV1l2a/OH3CC3McJ35cOzL27nYfmMTsD+xSgmJTvSMsnplF7 gj5b+nnBdLeiZRdAH4QckKw3GDvs8v1FSZzOE63s/c325fTog8sDHKPMGie6O9VWzt1HSn EEjgZharU/fg0LdQwjAi/bZnbWsrwmLchFiNDuC5cxsm8qjD11nMHBPWij93aul9yqxG2a LVmorgf7VY9Okmen3+hlkzN+OJGGzAhZWDBYKM9sQoZUxZ25VohPjdCfpuYAPg== Date: Thu, 2 May 2024 03:28:36 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240502012836.GC6420@pb2> References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-3-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/avfft: Remove dead code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7568983515342436347==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7568983515342436347== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r77VlXJNzFo8l631" Content-Disposition: inline --r77VlXJNzFo8l631 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 02, 2024 at 03:21:11AM +0200, Lynne wrote: > May 2, 2024, 02:42 by michael@niedermayer.cc: >=20 > > Fixes: CID1543204 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avfft.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c > > index f6787937f67..0f43f30b776 100644 > > --- a/libavcodec/avfft.c > > +++ b/libavcodec/avfft.c > > @@ -158,7 +158,7 @@ RDFTContext *av_rdft_init(int nbits, enum RDFTransf= ormType trans) > > return NULL; > > } > > =20 > > - s->stride =3D (trans =3D=3D DFT_C2R) ? sizeof(AVComplexFloat) : si= zeof(float); > > + s->stride =3D sizeof(float); > > s->len =3D 1 << nbits; > > s->inv =3D trans =3D=3D IDFT_C2R;=20 > > >=20 > That's not right. > While it's true that currently the stride parameter in av_tx_fn > is unused for RDFTs, that may not always be the case, and the > documentation requires that the stride is valid and set to the > value that the current implementation assumes, so that nothing > breaks once that is implemented. i kind of had the same feeling but wanted to post it anyway. so patch withdrawn, ill mark the issue as "intentional" in coverity thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --r77VlXJNzFo8l631 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjLsPQAKCRBhHseHBAsP q1iFAJ9i0uV6UnkilBJ0PJNGAE+AzlkG/QCeKfQPZ2z4aJgaLkW3m35gJHF76iE= =pEe2 -----END PGP SIGNATURE----- --r77VlXJNzFo8l631-- --===============7568983515342436347== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7568983515342436347==--