From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DEA7C48396 for ; Tue, 30 Apr 2024 20:40:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 271DC68D613; Tue, 30 Apr 2024 23:40:35 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9BE3068C3B1 for ; Tue, 30 Apr 2024 23:40:28 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CCED360006 for ; Tue, 30 Apr 2024 20:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714509628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qGLRsrRSfWb0QGTl6pdkQmlyo33PY2QYXfB9RQ628cw=; b=KqrLlvV+dsE1Sltv0dsHUPuNGGFDYFN/KjWS/snFktusoUmLTSuDW/gBy3kNF+PFa12uw8 LunaoQv+Mw2kI3a6geMtt1iyfqSb5FA83x87hJ+BMItltlUoojMwGYvYlL0EpKgEeE49XE vtPU8znKUacw2c3xL/bdA8xdHA8I8om0j0n5DbYQyxsX2x8XRbzygU6BHUoPTd/kHzR+LF /wizBSn8ydDufJq6rsBLQf/uwmAe6XzQt3oDrdn6AFQ/q/AF/t4HNHVkwdkuUCF2hDEP9a CZZ5eOM0GqnUGzjGUqqgtsuLD6XJRsk3RKkbOFKKb8oBO0BTNKysZVNrOznp5Q== Date: Tue, 30 Apr 2024 22:40:26 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240430204026.GS6420@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5288068475615638332==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5288068475615638332== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q7RvIXC4VLIim/2r" Content-Disposition: inline --Q7RvIXC4VLIim/2r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: > This avoids constant allocations+frees and will also allow > to simply switch to the RefStruct API, thereby avoiding > the overhead of the AVBuffer API. > It also simplifies the code, because it removes the "needs_realloc" > field: It was added in 435c0b87d28b48dc2e0360adc404a0e2d66d16a0, > before the introduction of the AVBuffer API: given that these buffers > may be used by different threads, they were not freed immediately > and instead were marked as being freed later by setting needs_realloc. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegpicture.c | 155 ++++++++----------------------------- > libavcodec/mpegpicture.h | 27 ++++--- > libavcodec/mpegvideo.c | 37 +++++++++ > libavcodec/mpegvideo.h | 2 + > libavcodec/mpegvideo_dec.c | 35 ++++----- > libavcodec/mpegvideo_enc.c | 13 ++-- > 6 files changed, 112 insertions(+), 157 deletions(-) This seems to change the output of: =2E/ffmpeg -y -bitexact -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -p= s 50 -bf 1 -bitexact -an -qscale 5 -ss 40 -error_rate 4 -threads 1 /tmp/ou= t4.avi && ./ffmpeg -y -bitexact -v -1 -loglevel 0 -i /tmp/out4.avi -bitexac= t -vsync drop -f framecrc - --- A 2024-04-30 22:01:12.964146819 +0200 +++ B 2024-04-30 22:00:57.407969834 +0200 @@ -38,7 +38,7 @@ 0, 32, 32, 1, 115200, 0x74c44bae 0, 33, 33, 1, 115200, 0x921c5255 0, 34, 34, 1, 115200, 0x9a8553a9 -0, 35, 35, 1, 115200, 0x817b6334 +0, 35, 35, 1, 115200, 0x310061fd 0, 36, 36, 1, 115200, 0x4c9a5f6d 0, 37, 37, 1, 115200, 0x5ee86279 0, 38, 38, 1, 115200, 0x04055061 @@ -74,7 +74,7 @@ 0, 68, 68, 1, 115200, 0x49dcbf4e 0, 69, 69, 1, 115200, 0x1ea1c7d1 0, 70, 70, 1, 115200, 0xdf77c67b -0, 71, 71, 1, 115200, 0x33d9d206 +0, 71, 71, 1, 115200, 0x7f6bd16d 0, 72, 72, 1, 115200, 0x5e37cb3a 0, 73, 73, 1, 115200, 0x15abcda3 0, 74, 74, 1, 115200, 0xbf4dcbd4 @@ -86,7 +86,7 @@ 0, 80, 80, 1, 115200, 0x17d1d667 0, 81, 81, 1, 115200, 0x0c1fdf9c 0, 82, 82, 1, 115200, 0x7eabde6b -0, 83, 83, 1, 115200, 0x3bf6e873 +0, 83, 83, 1, 115200, 0xe623e7af 0, 84, 84, 1, 115200, 0xf480dc82 0, 85, 85, 1, 115200, 0x5fd6e098 0, 86, 86, 1, 115200, 0xf520de95 @@ -98,7 +98,7 @@ 0, 92, 92, 1, 115200, 0x34cfe1c2 0, 93, 93, 1, 115200, 0x1d94e1c3 0, 94, 94, 1, 115200, 0x6d32e147 -0, 95, 95, 1, 115200, 0x09fbefd0 +0, 95, 95, 1, 115200, 0x7e40ee91 0, 96, 96, 1, 115200, 0xa5f5eb43 0, 97, 97, 1, 115200, 0x39b9ec3d 0, 98, 98, 1, 115200, 0x3256ec18 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus --Q7RvIXC4VLIim/2r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZjFXNAAKCRBhHseHBAsP q+TdAJ9ldd2R8YlZ9WGEHd75Ygf+P5Gz3ACePxZyvdL/ygI0DUfsGTe4+xhu96Q= =Cgj8 -----END PGP SIGNATURE----- --Q7RvIXC4VLIim/2r-- --===============5288068475615638332== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5288068475615638332==--