From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B0B9E48DE9 for ; Sat, 27 Apr 2024 23:54:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7964E68D2F2; Sun, 28 Apr 2024 02:54:32 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F19D368C9CC for ; Sun, 28 Apr 2024 02:54:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 22F7E20003 for ; Sat, 27 Apr 2024 23:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714262065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UKP08vNd9/FFnH7lCUk4Urxe1ly3sqkG+rzouGA/H8I=; b=Q7krBtxlrwpHetBxFkIbvwhsy+/m9hp/RXcBtTiWvHXReKs8jIa4tbQ8iv6rAOFMa79mmF F9wYeXjwST8388uO2gWjkeMsT4xAHVzourN7ty5D2mftdTBotO4aKhF+RySA/sWm2+o6fJ V9J1JEnrM0Ne42f5dECTdcNs3cvUK1/EUYmXzBget9Ylmmc7VDqPDiE0V0RXrJKfD95GZR YYxwtLLEnqnCQ9lAfhyBvi7MwP0loygJqW42pcfbnhkq4GS418OfLTaxRF+GG67Uac14Rs Bx2stM2bWRtI0J5DiFpvmf2P6RniGZ5BECmv/ZDSZxJReuXEfUTWYjs9Bvf05w== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 28 Apr 2024 01:54:15 +0200 Message-ID: <20240427235424.3075968-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_enc: simplify opaque_ref check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Found-while-revieweing: CID1520670 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 618ba193ff5..863d1a43edd 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -476,7 +476,7 @@ void enc_stats_write(OutputStream *ost, EncStats *es, const FrameData *fd; - if ((frame && frame->opaque_ref) || (pkt && pkt->opaque_ref)) { + if (frame ? frame->opaque_ref : pkt->opaque_ref) { fd = (const FrameData*)(frame ? frame->opaque_ref->data : pkt->opaque_ref->data); tbi = fd->dec.tb; ptsi = fd->dec.pts; -- 2.43.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".