From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D51D349AA2 for ; Sat, 27 Apr 2024 18:15:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F1F0E68D281; Sat, 27 Apr 2024 21:15:54 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 934D768D12C for ; Sat, 27 Apr 2024 21:15:48 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C675E1BF203 for ; Sat, 27 Apr 2024 18:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714241747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H1KT1BgQIdXZmtb3zzCc9lEJSkl8pcWWfLEIVAvTQNg=; b=PSi0Jx8rNG0okKS7ZxoygKKD78KYN5r9EHHRkOfivL66zexJXPL5TwZOrea27BD5gzs7M/ yH7cNuku+Z1ZuwHjRXK3IHoOSDwh/PGDD6r2hxDiujzod4kuczcTXuMnFNpE0zCetgUbBA K7XSstP1OOvqM09lOg2SsNrMRB7TdMd0RhEBUFaD6Y3B6ZThZ/gNrXQfq7SEW1xXjhKoum erOQU38hwhvZOh0A94VQVwwk9TJFGLdAuH+71Qi6YBjg6XUdUKJthGvr2U4GL3NQH6Hf/o HLx1JeppDdc/cPYj615BSEXXFguLiUgw9HVWui3MmlNMoaUf7xePTJUOf+u4WQ== Date: Sat, 27 Apr 2024 20:15:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240427181546.GG6420@pb2> References: <20240426235211.3718252-1-michael@niedermayer.cc> <20240426235211.3718252-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5759385408928454502==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5759385408928454502== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="27ly6Btvs/pOEClr" Content-Disposition: inline --27ly6Btvs/pOEClr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Sat, Apr 27, 2024 at 11:47:32AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:16= 88 > > Fixes: 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_f= uzzer-5942090287611904 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp3.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > > index 2a5f68dfa8e..09527607767 100644 > > --- a/libavcodec/vp3.c > > +++ b/libavcodec/vp3.c > > @@ -2651,6 +2651,7 @@ static int vp3_decode_frame(AVCodecContext *avctx= , AVFrame *frame, > > if (avctx->skip_frame >=3D AVDISCARD_NONKEY && !s->keyframe) > > return buf_size; > > =20 > > + ff_progress_frame_unref(&s->current_frame); > > ret =3D ff_progress_frame_get_buffer(avctx, &s->current_frame, > > AV_GET_BUFFER_FLAG_REF); > > if (ret < 0) { >=20 > LGTM. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator --27ly6Btvs/pOEClr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZi1A0gAKCRBhHseHBAsP q4apAJ9WCFBd42YHiE/DfD0Awf9DhuFQWQCaA7pgEywxFovEe8Sj/igMiKeWP9I= =abpr -----END PGP SIGNATURE----- --27ly6Btvs/pOEClr-- --===============5759385408928454502== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5759385408928454502==--