From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 782EF499E0 for ; Sat, 27 Apr 2024 00:03:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E06A68C248; Sat, 27 Apr 2024 03:03:10 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35FC168C248 for ; Sat, 27 Apr 2024 03:03:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 92E7B240005 for ; Sat, 27 Apr 2024 00:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714176182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6N93C8TibAYQRNbuG1A8GdEyq8j3C6Bs4f8lCM3ci3M=; b=GPlzmJElnTwoL0LmlG/6fM3aYPAjQ3B+eSPrLXrh2ijNCU28+fikCnDS+Z/5G/Q2te///G BLKjF/s8Q6lhnj5vRuCs8cqd4eVoB7RcxVaSC/T/ONo2Uw8j5ReYoPZ0/Tiz5Yyr3UZqtj 2WxwR9zTu3pd8Gnc5UcIGL2I+inwDPkXS4Vy1jAEyPc3HLaJ/L4g0L3kZ00fBxEOgQv+5M P1KdCK5Sn/g0smOHrqKegTOq+67n/zyhHtRIwSOV0ClDT3NaBgrJu3aYXc6eUDBgVfdEXz zVdO8TGr7iZNG939pn94U/ibSCr+LZK7swcbmBLuoNRsy2rux+4Gg6qTkTiPhQ== Date: Sat, 27 Apr 2024 02:03:01 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240427000301.GZ6420@pb2> References: <20240426235211.3718252-1-michael@niedermayer.cc> <20240426235211.3718252-5-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: Check if heif item name is already allocated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8240210260218012042==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8240210260218012042== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RZdy5h1Ivmfqh1br" Content-Disposition: inline --RZdy5h1Ivmfqh1br Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 26, 2024 at 08:57:02PM -0300, James Almer wrote: > On 4/26/2024 8:52 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: 68212/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-49634= 88540721152 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 97a24e6737e..5b8278f736e 100644 > > --- a/libavformat/mov.c > > +++ b/libavformat/mov.c > > @@ -8136,6 +8136,9 @@ static int mov_read_infe(MOVContext *c, AVIOConte= xt *pb, MOVAtom atom, int idx) > > avio_rb24(pb); // flags. > > size -=3D 4; > > + if (c->heif_item[idx].name) > > + return AVERROR_INVALIDDATA; >=20 > I prefer to free the old one before the av_bprint_finalize() call instead= of > aborting. does the format allow this to be changing ? because security wise, allowing an attacker to change things is worse than allowing her to just set it once. and heif seems to have a rather high density of issues already, judging =66rom how many of the recent mov issues where in heif code thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --RZdy5h1Ivmfqh1br Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZixAsgAKCRBhHseHBAsP q0wMAJ9976OdjsBbVIELqTLDg8hS02kncwCdG/F/soTmTRW4cfpojBU9BybVlmg= =arCM -----END PGP SIGNATURE----- --RZdy5h1Ivmfqh1br-- --===============8240210260218012042== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8240210260218012042==--