[FFmpeg-devel] [PATCH] avcodec/bsf/noise: fix av_log format specifier

From: Marcus B Spencer <marcus@marcusspencer.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Marcus B Spencer <marcus@marcusspencer.xyz>
Subject: [FFmpeg-devel] [PATCH] avcodec/bsf/noise: fix av_log format specifier
Date: Fri, 26 Apr 2024 12:30:57 -0500
Message-ID: <20240426173057.259957-1-marcus@marcusspencer.xyz> (raw)
In-Reply-To: <GEsTrbkwAg4ThBpZC59Y6dKoDT5SxHtHCV9fufDBtG7wKAAzjGbUmj_g4iRHVhbyIALZXHHUnns8Z2PpsEfGtzqwDjQi4NrAl8Zo9C4f0yU=@marcusspencer.xyz>

Replace the "%d" specifier corresponding to the 2nd argument of av_log starting on line 176 with "%u", due to the fact that the 2nd argument is an unsigned int. Without this patch, if the second argument exceeded the maximum value of an int, the behavior would be undefined.

Signed-off-by: Marcus B Spencer <marcus@marcusspencer.xyz>
---
 libavcodec/bsf/noise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
index a622855717..d36be5fab4 100644
--- a/libavcodec/bsf/noise.c
+++ b/libavcodec/bsf/noise.c
@@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
         drop = !(s->state % s->dropamount);
     }
 
-    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
+    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
            pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
 
     if (drop) {
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
