[FFmpeg-devel] [PATCH] fix av_log format specifier

[FFmpeg-devel] [PATCH] fix av_log format specifier

[Marcus B Spencer]

Signed-off-by: Marcus B Spencer <marcus@marcusspencer.xyz>
---
 libavcodec/bsf/noise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
index a622855717..d36be5fab4 100644
--- a/libavcodec/bsf/noise.c
+++ b/libavcodec/bsf/noise.c
@@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
         drop = !(s->state % s->dropamount);
     }
 
-    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
+    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
            pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
 
     if (drop) {
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fix av_log format specifier

[marcus]

This patch does not meet the guidelines of commit messages.




On Thursday, April 25th, 2024 at 6:02 PM, Marcus B Spencer <marcus@marcusspencer.xyz> wrote:

> 
> 
> Signed-off-by: Marcus B Spencer marcus@marcusspencer.xyz
> 
> ---
> libavcodec/bsf/noise.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
> index a622855717..d36be5fab4 100644
> --- a/libavcodec/bsf/noise.c
> +++ b/libavcodec/bsf/noise.c
> @@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
> drop = !(s->state % s->dropamount);
> 
> }
> 
> - av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
> + av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
> pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
> 
> 
> if (drop) {
> --
> 2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/bsf/noise: fix av_log format specifier

[Marcus B Spencer]

Replace the "%d" specifier corresponding to the 2nd argument of av_log starting on line 176 with "%u", due to the fact that the 2nd argument is an unsigned int. Without this patch, if the second argument exceeded the maximum value of an int, the behavior would be undefined.

Signed-off-by: Marcus B Spencer <marcus@marcusspencer.xyz>
---
 libavcodec/bsf/noise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/bsf/noise.c b/libavcodec/bsf/noise.c
index a622855717..d36be5fab4 100644
--- a/libavcodec/bsf/noise.c
+++ b/libavcodec/bsf/noise.c
@@ -173,7 +173,7 @@ static int noise(AVBSFContext *ctx, AVPacket *pkt)
         drop = !(s->state % s->dropamount);
     }
 
-    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %d pts %"PRId64" - amount %d drop %d\n",
+    av_log(ctx, AV_LOG_VERBOSE, "Stream #%d packet %u pts %"PRId64" - amount %d drop %d\n",
            pkt->stream_index, (unsigned int)s->var_values[VAR_N], pkt->pts, amount, drop);
 
     if (drop) {
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".