From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF4EB49999 for ; Thu, 25 Apr 2024 00:59:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44A0968D383; Thu, 25 Apr 2024 03:59:30 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A850468BEFE for ; Thu, 25 Apr 2024 03:59:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 03FF640002 for ; Thu, 25 Apr 2024 00:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1714006763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MAYApYFlPPY6Oz79EU2+B2Idp4ltuqUY14X6gv5t7G0=; b=cow5G5aoynX6QsqT76eCaAw+8Mon3Jp0ocLUvl6tei6DROoLZbak5GP63sVrmboFGClgYl f8npk8yU0bRmb79wYFmsCong+lq0H6JOy0bZQkWMKML4CXdBZEIwxdYUe5Cx4nXJClR1oz 1vyyJtZanvtVI7PwbYvfuSPWCd1xpyC4r/fdhR+4CQA5XFI54aXADi4q4I1127vKzIQzKK R6PzgYpUY1mGym6BwdlO5KVY4s34zfxNhkPcI2C4+iqFlaFNRBUpVxvtBMOVbhwIKeTMIo UWi63YYHJ1U/bWhm0aURaU+JEhVjDi1lrSgdOP/8yvZjfV/abftmO8j572ir8A== Date: Thu, 25 Apr 2024 02:59:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240425005921.GY6420@pb2> References: <309dc932-eca9-42a6-a0b8-97827065647c@mediaarea.net> MIME-Version: 1.0 In-Reply-To: <309dc932-eca9-42a6-a0b8-97827065647c@mediaarea.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0467021146168143689==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0467021146168143689== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uorlF3idqv6dj7tA" Content-Disposition: inline --uorlF3idqv6dj7tA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 24, 2024 at 01:20:02PM +0200, Jerome Martinez wrote: > Hi, I'm bumping this patch proposal for avoiding a situation where FFmpeg > skips half the visual content when 2 jpeg2000 codestreams are present in = one > frame. I re-reviewed this discussion and think I answered all concerns. I= 'm > hesitant with patch v3 because I consider that touching frame_worker_thre= ad > for this feature is not so useful but I am ok with either patch v2 or v3. > Thanks much, > =A0=A0=A0 J=E9r=F4me I hope i applied the correct patch: libavcodec/avcodec.h | 14 ++++++++++++++ libavcodec/codec_par.c | 3 +++ libavcodec/codec_par.h | 5 +++++ libavcodec/decode.c | 3 +++ libavcodec/defs.h | 7 +++++++ libavcodec/jpeg2000dec.c | 73 ++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++---------- libavcodec/jpeg2000dec.h | 6 ++++++ libavcodec/pthread_frame.c | 3 +++ libavformat/mxfdec.c | 14 ++++++++++++++ 9 files changed, 118 insertions(+), 10 deletions(-) but that with: =2E/ffmpeg -i ~/tickets/1102/ntsc2.mxf -bitexact -vframes 1 /tmp/file.bmp segafaults: =3D=3D1031087=3D=3D Invalid write of size 2 =3D=3D1031087=3D=3D at 0x9D758F: jpeg2000_decode_tile (in ffmpeg/ffmpeg_= g) =3D=3D1031087=3D=3D by 0x7C3820: avcodec_default_execute2 (in ffmpeg/ffm= peg_g) =3D=3D1031087=3D=3D by 0x9DCE6E: jpeg2000_decode_frame (in ffmpeg/ffmpeg= _g) =3D=3D1031087=3D=3D by 0xAF912F: frame_worker_thread (in ffmpeg/ffmpeg_g) =3D=3D1031087=3D=3D by 0x4A00608: start_thread (pthread_create.c:477) =3D=3D1031087=3D=3D by 0x8104352: clone (clone.S:95) =3D=3D1031087=3D=3D Address 0x0 is not stack'd, malloc'd or (recently) fre= e'd [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --uorlF3idqv6dj7tA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZimq3wAKCRBhHseHBAsP q+0DAKCCbRU5VLTrg0RI570XjUdwMccx8ACgmHqGCH/Sf6+CyobhiURZhs8OlFY= =PxNq -----END PGP SIGNATURE----- --uorlF3idqv6dj7tA-- --===============0467021146168143689== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0467021146168143689==--