From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 6B9474A241
	for <ffmpegdev@gitmailbox.com>; Thu, 25 Apr 2024 00:08:20 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C9A1468D37B;
	Thu, 25 Apr 2024 03:08:18 +0300 (EEST)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
 [217.70.183.197])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E097168D1E0
 for <ffmpeg-devel@ffmpeg.org>; Thu, 25 Apr 2024 03:08:11 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 447E71C0006
 for <ffmpeg-devel@ffmpeg.org>; Thu, 25 Apr 2024 00:08:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1714003691;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=xfOK+ELsz3+A8oTt54EaNtHSnMmFYMKpIZfqp5fvsJo=;
 b=OsecTRzQHC9tzLQS3gXkeIkjtLR5xPMcARFjPbaEEmhzp6G62jTD8z6X9T126aQg9lkQDT
 g20Yt34cIvKyKK0JGH3+/vL9TDicFhMZoYvm6z5XTYpI0eV9EexJ1/AI2uMl53tObYOLiG
 sR8QoEUk189tRkrDWxtmH2z8B/tBIt7tKsLSh+AVkl1lJv87xOdkTwIFV0fu9034ixV25t
 HPMgUMarRutN+HUzi2/+I5UjMIvth/MRXg+rWQKV2X8pooZ0SGtLm57fX6DDeA4ahXsBPu
 U/olm0sudsnDW96rGEARyEL9w6ED6KJ8EzukVwYv6XTLDxw6VkCYnuNhDhb5kQ==
Date: Thu, 25 Apr 2024 02:08:10 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20240425000810.GX6420@pb2>
References: <NwEJ54_--3-9@lynne.ee> <NwEJ54_--3-9@lynne.ee-NwEJ9Lk----9>
 <NwEkXbX--3-9@lynne.ee>
MIME-Version: 1.0
In-Reply-To: <NwEkXbX--3-9@lynne.ee>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v2] opusdsp: add ability to modify
 deemphasis constant
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============6076322658135110694=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240425000810.GX6420@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============6076322658135110694==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="OjC432LN4jg5ONQ8"
Content-Disposition: inline


--OjC432LN4jg5ONQ8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 24, 2024 at 12:58:54PM +0200, Lynne wrote:
> Apr 24, 2024, 10:54 by dev@lynne.ee:
>=20
> > xHE-AAC relies on the same postfilter mechanism
> > that Opus uses to improve clarity (albeit with a steeper
> > deemphasis filter).
> >
> > The code to apply it is identical, it's still just a
> > simple IIR low-pass filter. This commit makes it possible
> > to use alternative constants.
> >
> > Version 2 changes:
> > Move the deemphasis constant table to opustab.c and
> > document its values better.
> >
>=20
> v3 attached, forgot to port the native opus encoder.

make V=3D2 fate-checkasm-opusdsp
TEST    checkasm-opusdsp
=2E/tests/fate-run.sh fate-checkasm-opusdsp "/home/michael/fatesamples/fate=
/fate-suite/" "" "/home/michael/ffmpeg-git/ffmpeg" 'run tests/checkasm/chec=
kasm --test=3Dopusdsp' 'null' '' '' '1' '' '' '' '' '' '' '' '' '' ''
 /home/michael/ffmpeg-git/ffmpeg/tests/checkasm/checkasm --test=3Dopusdsp
Test checkasm-opusdsp failed. Look at tests/data/fate/checkasm-opusdsp.err =
for details.
checkasm: using random seed 4190264620
FMA3:
 - opusdsp.postfilter_15   [OK]
 - opusdsp.postfilter_512  [OK]
 - opusdsp.postfilter_1022 [OK]
   deemphasis_fma3 (fatal signal 11: Segmentation fault)
 - opusdsp.deemphasis      [FAILED]
checkasm: 1 of 4 tests have failed
threads=3D1
make: *** [tests/Makefile:311: fate-checkasm-opusdsp] Error 1

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell

--OjC432LN4jg5ONQ8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZime6gAKCRBhHseHBAsP
q6X1AJ0bQ8xHotT+HrqiiDcDAqx1NTXgSwCgiNrhM2kYQzZ3MOW/efR2MY+rmYc=
=j/cg
-----END PGP SIGNATURE-----

--OjC432LN4jg5ONQ8--

--===============6076322658135110694==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============6076322658135110694==--