From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF64048D6F for ; Wed, 24 Apr 2024 21:07:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E538868D370; Thu, 25 Apr 2024 00:07:26 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AA10F68D12C for ; Thu, 25 Apr 2024 00:07:19 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E48AA60003 for ; Wed, 24 Apr 2024 21:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713992839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FoWruEfrz5CPp87t/5++/rNPzMf6ypL2JQ4HVF0JDdo=; b=Itqx5jVmHgrTAQAWVHCce2LoQpHoDhfrnL0STkO/EOA7wyhvMB0n+UTAeaJk9DQpG1P+W2 nlnREPh4hAm7Dyli0lzcFUfeiC2urAs9rL2oFobh8FszCKt4mMqA/feJLmFgET4EdAMGfA u8RexOMsPn4MSRcB4bI5hqiEjdLsx21aKvJkxfzRKs6bYkTzkoYjnH5kSYm3WI5M/T9rWl xa+Gd+y71vzPCGOJWWUZe+AnaCJfoCuA8OG9pK3Pok3g+C1ZOR5v4ipcODTP+xpXud4y1x v/kKt3otVgmXhZSKWGnbkbXsPXf11GTWI4tTMk54DyeGNoPXUzHyxtbeTscfGg== Date: Wed, 24 Apr 2024 23:07:17 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240424210717.GU6420@pb2> References: <20240424014522.4015429-1-michael@niedermayer.cc> <20240424014522.4015429-4-michael@niedermayer.cc> <1049374fadd38cf88d2a953aa07b4703ce052ab6.camel@intel.com> MIME-Version: 1.0 In-Reply-To: <1049374fadd38cf88d2a953aa07b4703ce052ab6.camel@intel.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5978639544628316270==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5978639544628316270== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dOzi9VYiLOlOzQqf" Content-Disposition: inline --dOzi9VYiLOlOzQqf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 24, 2024 at 05:18:55AM +0000, Xiang, Haihao wrote: > On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > > Fixes: CID1517022 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > =A0doc/examples/qsv_transcode.c | 3 +-- > > =A01 file changed, 1 insertion(+), 2 deletions(-) > >=20 > > diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c > > index a4440a3403f..8e843ddd84c 100644 > > --- a/doc/examples/qsv_transcode.c > > +++ b/doc/examples/qsv_transcode.c > > @@ -76,8 +76,7 @@ static int str_to_dict(char* optstr, AVDictionary **o= pt) > > =A0=A0=A0=A0=A0=A0=A0=A0 if (value =3D=3D NULL) > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR(EINVAL); > > =A0=A0=A0=A0=A0=A0=A0=A0 av_dict_set(opt, key, value, 0); > > -=A0=A0=A0 } while(key !=3D NULL); > > -=A0=A0=A0 return 0; > > +=A0=A0=A0 } while(1); > > =A0} > > =A0 > > =A0static int dynamic_set_parameter(AVCodecContext *avctx) >=20 > LGTM, thanks for catching & fixing this. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --dOzi9VYiLOlOzQqf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZil0hQAKCRBhHseHBAsP q2rLAJsGOqFqGhY51dXAchJ5X+nv/PzIVACeM9ZqZXzejZtMjEQDtaQ9+VdLzVU= =mUbK -----END PGP SIGNATURE----- --dOzi9VYiLOlOzQqf-- --===============5978639544628316270== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5978639544628316270==--