* [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required @ 2024-04-24 14:09 J. Dekker 2024-04-24 14:09 ` [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths J. Dekker 2024-05-02 15:40 ` [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required Rémi Denis-Courmont 0 siblings, 2 replies; 6+ messages in thread From: J. Dekker @ 2024-04-24 14:09 UTC (permalink / raw) To: ffmpeg-devel Signed-off-by: J. Dekker <jdek@itanimul.li> --- libavfilter/riscv/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/riscv/Makefile b/libavfilter/riscv/Makefile index 0b968a9c0d..277dde2aed 100644 --- a/libavfilter/riscv/Makefile +++ b/libavfilter/riscv/Makefile @@ -1,2 +1,2 @@ -OBJS += riscv/af_afir_init.o -RVV-OBJS += riscv/af_afir_rvv.o +OBJS-$(CONFIG_AFIR_FILTER) += riscv/af_afir_init.o +RVV-OBJS-$(CONFIG_AFIR_FILTER) += riscv/af_afir_rvv.o -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths 2024-04-24 14:09 [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required J. Dekker @ 2024-04-24 14:09 ` J. Dekker 2024-05-02 15:42 ` Rémi Denis-Courmont 2024-05-02 16:33 ` Devin Heitmueller 2024-05-02 15:40 ` [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required Rémi Denis-Courmont 1 sibling, 2 replies; 6+ messages in thread From: J. Dekker @ 2024-04-24 14:09 UTC (permalink / raw) To: ffmpeg-devel Signed-off-by: J. Dekker <jdek@itanimul.li> --- tests/checkasm/h264dsp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index 0f484e3f43..5cb646ae49 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth) static void check_idct(void) { + static const int depths[5] = { 8, 9, 10, 12, 14 }; LOCAL_ALIGNED_16(uint8_t, src, [8 * 8 * 2]); LOCAL_ALIGNED_16(uint8_t, dst, [8 * 8 * 2]); LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]); @@ -181,10 +182,11 @@ static void check_idct(void) LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]); LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]); H264DSPContext h; - int bit_depth, sz, align, dc; + int bit_depth, sz, align, dc, i; declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride); - for (bit_depth = 8; bit_depth <= 10; bit_depth++) { + for (i = 0; i < 5; i++) { + bit_depth = depths[i]; ff_h264dsp_init(&h, bit_depth, 1); for (sz = 4; sz <= 8; sz += 4) { randomize_buffers(); -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths 2024-04-24 14:09 ` [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths J. Dekker @ 2024-05-02 15:42 ` Rémi Denis-Courmont 2024-05-02 16:33 ` Devin Heitmueller 1 sibling, 0 replies; 6+ messages in thread From: Rémi Denis-Courmont @ 2024-05-02 15:42 UTC (permalink / raw) To: ffmpeg-devel Le keskiviikkona 24. huhtikuuta 2024, 17.09.44 EEST J. Dekker a écrit : > Signed-off-by: J. Dekker <jdek@itanimul.li> > --- > tests/checkasm/h264dsp.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c > index 0f484e3f43..5cb646ae49 100644 > --- a/tests/checkasm/h264dsp.c > +++ b/tests/checkasm/h264dsp.c > @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth) > > static void check_idct(void) > { > + static const int depths[5] = { 8, 9, 10, 12, 14 }; > LOCAL_ALIGNED_16(uint8_t, src, [8 * 8 * 2]); > LOCAL_ALIGNED_16(uint8_t, dst, [8 * 8 * 2]); > LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]); > @@ -181,10 +182,11 @@ static void check_idct(void) > LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]); > LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]); > H264DSPContext h; > - int bit_depth, sz, align, dc; > + int bit_depth, sz, align, dc, i; > declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, > int stride); > > - for (bit_depth = 8; bit_depth <= 10; bit_depth++) { > + for (i = 0; i < 5; i++) { > + bit_depth = depths[i]; > ff_h264dsp_init(&h, bit_depth, 1); > for (sz = 4; sz <= 8; sz += 4) { > randomize_buffers(); Fine with me, but then again, this is not RISC-V-specific, and other people are ostensibly better for reviewing checkasm changes. -- Rémi Denis-Courmont http://www.remlab.net/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths 2024-04-24 14:09 ` [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths J. Dekker 2024-05-02 15:42 ` Rémi Denis-Courmont @ 2024-05-02 16:33 ` Devin Heitmueller 2024-05-14 15:59 ` J. Dekker 1 sibling, 1 reply; 6+ messages in thread From: Devin Heitmueller @ 2024-05-02 16:33 UTC (permalink / raw) To: FFmpeg development discussions and patches On Wed, Apr 24, 2024 at 10:10 AM J. Dekker <jdek@itanimul.li> wrote: > > Signed-off-by: J. Dekker <jdek@itanimul.li> > --- > tests/checkasm/h264dsp.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c > index 0f484e3f43..5cb646ae49 100644 > --- a/tests/checkasm/h264dsp.c > +++ b/tests/checkasm/h264dsp.c > @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth) > > static void check_idct(void) > { > + static const int depths[5] = { 8, 9, 10, 12, 14 }; > LOCAL_ALIGNED_16(uint8_t, src, [8 * 8 * 2]); > LOCAL_ALIGNED_16(uint8_t, dst, [8 * 8 * 2]); > LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]); > @@ -181,10 +182,11 @@ static void check_idct(void) > LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]); > LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]); > H264DSPContext h; > - int bit_depth, sz, align, dc; > + int bit_depth, sz, align, dc, i; > declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride); > > - for (bit_depth = 8; bit_depth <= 10; bit_depth++) { > + for (i = 0; i < 5; i++) { > + bit_depth = depths[i]; Perhaps this should use FF_ARRAY_ELEMS(depths) rather than a hard-coded "5"? Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths 2024-05-02 16:33 ` Devin Heitmueller @ 2024-05-14 15:59 ` J. Dekker 0 siblings, 0 replies; 6+ messages in thread From: J. Dekker @ 2024-05-14 15:59 UTC (permalink / raw) To: ffmpeg-devel Devin Heitmueller <devin.heitmueller@ltnglobal.com> writes: > On Wed, Apr 24, 2024 at 10:10 AM J. Dekker <jdek@itanimul.li> wrote: >> >> Signed-off-by: J. Dekker <jdek@itanimul.li> >> --- >> tests/checkasm/h264dsp.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c >> index 0f484e3f43..5cb646ae49 100644 >> --- a/tests/checkasm/h264dsp.c >> +++ b/tests/checkasm/h264dsp.c >> @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth) >> >> static void check_idct(void) >> { >> + static const int depths[5] = { 8, 9, 10, 12, 14 }; >> LOCAL_ALIGNED_16(uint8_t, src, [8 * 8 * 2]); >> LOCAL_ALIGNED_16(uint8_t, dst, [8 * 8 * 2]); >> LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]); >> @@ -181,10 +182,11 @@ static void check_idct(void) >> LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]); >> LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]); >> H264DSPContext h; >> - int bit_depth, sz, align, dc; >> + int bit_depth, sz, align, dc, i; >> declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride); >> >> - for (bit_depth = 8; bit_depth <= 10; bit_depth++) { >> + for (i = 0; i < 5; i++) { >> + bit_depth = depths[i]; > > Perhaps this should use FF_ARRAY_ELEMS(depths) rather than a hard-coded "5"? Thanks for the suggestion, pushed with this change. -- jd _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required 2024-04-24 14:09 [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required J. Dekker 2024-04-24 14:09 ` [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths J. Dekker @ 2024-05-02 15:40 ` Rémi Denis-Courmont 1 sibling, 0 replies; 6+ messages in thread From: Rémi Denis-Courmont @ 2024-05-02 15:40 UTC (permalink / raw) To: ffmpeg-devel Le keskiviikkona 24. huhtikuuta 2024, 17.09.43 EEST J. Dekker a écrit : > Signed-off-by: J. Dekker <jdek@itanimul.li> > --- > libavfilter/riscv/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/riscv/Makefile b/libavfilter/riscv/Makefile > index 0b968a9c0d..277dde2aed 100644 > --- a/libavfilter/riscv/Makefile > +++ b/libavfilter/riscv/Makefile > @@ -1,2 +1,2 @@ > -OBJS += riscv/af_afir_init.o > -RVV-OBJS += riscv/af_afir_rvv.o > +OBJS-$(CONFIG_AFIR_FILTER) += riscv/af_afir_init.o > +RVV-OBJS-$(CONFIG_AFIR_FILTER) += riscv/af_afir_rvv.o LGTM -- レミ・デニ-クールモン http://www.remlab.net/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-14 16:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-04-24 14:09 [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required J. Dekker 2024-04-24 14:09 ` [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths J. Dekker 2024-05-02 15:42 ` Rémi Denis-Courmont 2024-05-02 16:33 ` Devin Heitmueller 2024-05-14 15:59 ` J. Dekker 2024-05-02 15:40 ` [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required Rémi Denis-Courmont
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git