From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libx265: implement dolby vision coding
Date: Tue, 23 Apr 2024 07:49:56 +0200
Message-ID: <20240423054956.GH6420@pb2> (raw)
In-Reply-To: <8c655f9a-78cb-4dd2-99dd-58545479085c@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2695 bytes --]
On Mon, Apr 22, 2024 at 09:42:11PM -0300, James Almer wrote:
> On 4/22/2024 9:36 PM, Michael Niedermayer wrote:
> > On Mon, Apr 22, 2024 at 10:24:18AM +0000, Niklas Haas wrote:
> > > ffmpeg | branch: master | Niklas Haas <git@haasn.dev> | Fri Mar 29 13:14:54 2024 +0100| [39ca87ed1ef876af9622a5aa331e18167fdfdf27] | committer: Niklas Haas
> > >
> > > avcodec/libx265: implement dolby vision coding
> > >
> > > libx265 supports these natively, we just need to attach the generated
> > > NALs to the x265picture, as well as setting the appropriate DV profile.
> > >
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=39ca87ed1ef876af9622a5aa331e18167fdfdf27
> > > ---
> > >
> > > configure | 2 +-
> > > libavcodec/libx265.c | 40 ++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 41 insertions(+), 1 deletion(-)
> >
> > breaks build here, not sure why i didnt notice this before (i should have)
> >
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
> > libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
> > libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
> > libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
> > libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
> > libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
> > /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
> > libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
> > collect2: error: ld returned 1 exit status
> > collect2: error: ld returned 1 exit status
> > collect2: error: ld returned 1 exit status
> > make: *** [Makefile:136: ffmpeg_g] Error 1
> > make: *** Waiting for unfinished jobs....
> > make: *** [Makefile:136: ffplay_g] Error 1
> > make: *** [Makefile:136: ffprobe_g] Error 1
>
> Should be fixed by 3032a74cac4f7979d6e70db80360634e48e13827, can you rerun
> configure and check?
works fine,
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Elect your leaders based on what they did after the last election, not
based on what they say before an election.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-23 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240422102419.4DF4641172C@natalya.videolan.org>
2024-04-23 0:36 ` Michael Niedermayer
2024-04-23 0:42 ` James Almer
2024-04-23 5:49 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423054956.GH6420@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git