From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 67DFD4832A for ; Tue, 23 Apr 2024 00:37:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21CEB68D37D; Tue, 23 Apr 2024 03:37:04 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 530AE68CFF4 for ; Tue, 23 Apr 2024 03:36:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B4C35240002 for ; Tue, 23 Apr 2024 00:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713832616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OrK1ATSkD3BKC7Zj0TnhPh4dm4ZqJQh3E9DRD48/xrY=; b=V2NUJiXEG1zPCLVQR1HNUn4DWM2RqWAnGXD9iWM6B9LfbgKwTqvhChym1o4kRrY2Wdyzuo xHr3ivzx7O1Ag07+x7qa0U7lVHBY2Ldnu85KniVr3fDMCID1zpEgIrNANHPmFu9n+g64YJ hfZrW73xJ8HZ5+zAyQx/5N3snsy/O2GonbQKNWrPug1TMVTQ8Q92ZZped3einKdR+dNhpd mEFXLBgjwAdXotTckuAUgHQwF97NdAFbZ15GBgGrXNIJHhDS9ECrAfWYa3oihgFUHCT6e/ xZfYHmqYOg4XWVwtd/q2Iz3tUOmcyvJ2fVJMiGhiiucs9w1x/ovtBH2RxaKazQ== Date: Tue, 23 Apr 2024 02:36:55 +0200 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20240423003655.GA2436607@pb2> References: <20240422102419.4DF4641172C@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20240422102419.4DF4641172C@natalya.videolan.org> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libx265: implement dolby vision coding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6891268342406204604==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6891268342406204604== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 22, 2024 at 10:24:18AM +0000, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Fri Mar 29 13:14:= 54 2024 +0100| [39ca87ed1ef876af9622a5aa331e18167fdfdf27] | committer: Nikl= as Haas >=20 > avcodec/libx265: implement dolby vision coding >=20 > libx265 supports these natively, we just need to attach the generated > NALs to the x265picture, as well as setting the appropriate DV profile. >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D39ca87ed1= ef876af9622a5aa331e18167fdfdf27 > --- >=20 > configure | 2 +- > libavcodec/libx265.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 1 deletion(-) breaks build here, not sure why i didnt notice this before (i should have) /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_init': libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure' /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_frame.cold': libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_gene= rate' /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_init': libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure' /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_frame.cold': libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_gene= rate' /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_init': libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure' /usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encod= e_frame.cold': libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_gene= rate' collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status make: *** [Makefile:136: ffmpeg_g] Error 1 make: *** Waiting for unfinished jobs.... make: *** [Makefile:136: ffplay_g] Error 1 make: *** [Makefile:136: ffprobe_g] Error 1 ii libx265-dev:amd64 3.2.1-1build1 amd64 H.265/HEVC video stream en= coder (development files) thats a ubuntu 20.04 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZicCowAKCRBhHseHBAsP q+YMAJ4lI6t6MWZR7mETPtItVvjN5cfJ6wCfdyMP9HLkSLDBN3PuFeYoKmMTOnA= =XCQV -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- --===============6891268342406204604== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6891268342406204604==--