On Mon, Apr 22, 2024 at 10:24:18AM +0000, Niklas Haas wrote:
> ffmpeg | branch: master | Niklas Haas <git@haasn.dev> | Fri Mar 29 13:14:54 2024 +0100| [39ca87ed1ef876af9622a5aa331e18167fdfdf27] | committer: Niklas Haas
> 
> avcodec/libx265: implement dolby vision coding
> 
> libx265 supports these natively, we just need to attach the generated
> NALs to the x265picture, as well as setting the appropriate DV profile.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=39ca87ed1ef876af9622a5aa331e18167fdfdf27
> ---
> 
>  configure            |  2 +-
>  libavcodec/libx265.c | 40 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+), 1 deletion(-)

breaks build here, not sure why i didnt notice this before (i should have)

/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_init':
libx265.c:(.text.unlikely+0xd9c): undefined reference to `ff_dovi_configure'
/usr/bin/ld: libavcodec/libavcodec.a(libx265.o): in function `libx265_encode_frame.cold':
libx265.c:(.text.unlikely+0x1360): undefined reference to `ff_dovi_rpu_generate'
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
make: *** [Makefile:136: ffmpeg_g] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:136: ffplay_g] Error 1
make: *** [Makefile:136: ffprobe_g] Error 1

ii  libx265-dev:amd64 3.2.1-1build1 amd64        H.265/HEVC video stream encoder (development files)
thats a ubuntu 20.04

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
than the original author, trying to rewrite it will not make it better.