From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8007A4A1A9 for ; Mon, 22 Apr 2024 20:48:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9884A68D332; Mon, 22 Apr 2024 23:48:11 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A00D68CBEB for ; Mon, 22 Apr 2024 23:48:05 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C270FC0005 for ; Mon, 22 Apr 2024 20:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713818884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kcxdoIlU1WXvf1f3E3u6jm6moLTis0+QW6xuTw1cXjA=; b=Z5CaJXE8w6SD8xC/02ekRraKXHqS6XuQLdGynhnet5a8PFI+SwPL7nNp1tF7bhTU0rXEKU F1DmSmkz7pXsvMlsJq/TOjjLiPumN0pmPW2rHAtq0g6lZbGo8/g1Nm2XYGyEf+3W36YBRs pQJ7hybQfTccr2bG63CJlbtboD7rbj/d++XnG+Aw9t42WSmuLUrWcvdUWg/YR8de26LDn/ NdQiTimFMhkS08Jb5Wb4AWqXJaUy+j/+88E6SUvg8PnKQcsrWG7fu8qrg3G+kg2Ksatoj8 Ara27vIC9xQOQsHeW3xiaJy4/nt7m6U7wHPsqj6H6DgrqL1VtnYWwM+Pjw5zfQ== Date: Mon, 22 Apr 2024 22:48:02 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240422204802.GC6420@pb2> References: <20240422011159.4180004-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4473531416134440544==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4473531416134440544== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Lduk49ttrkmpKD4" Content-Disposition: inline --3Lduk49ttrkmpKD4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 22, 2024 at 12:17:02PM +0200, Timo Rothenpieler wrote: >=20 >=20 > On 22.04.2024 03:11, Michael Niedermayer wrote: > > Fixes: CID1418336 Logically dead code > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_thumbnail_cuda.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail= _cuda.c > > index 0459070800a..8efb54f0792 100644 > > --- a/libavfilter/vf_thumbnail_cuda.c > > +++ b/libavfilter/vf_thumbnail_cuda.c > > @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFra= me *frame) > > hist[i] =3D 4 * hist[i]; > > } > > - CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > > + ret =3D CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > > if (ret < 0) > > return ret; >=20 > LGTM will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates --3Lduk49ttrkmpKD4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZibM/gAKCRBhHseHBAsP q3LoAJwKcd62yrt81R5VdoUSPtuBLhmf4QCeIuonioxtfMTbH28HS9v3Nc9TmZc= =PN0z -----END PGP SIGNATURE----- --3Lduk49ttrkmpKD4-- --===============4473531416134440544== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4473531416134440544==--