[FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it

[FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it

[Michael Niedermayer]

Fixes: CID1418336 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavfilter/vf_thumbnail_cuda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
index 0459070800a..8efb54f0792 100644
--- a/libavfilter/vf_thumbnail_cuda.c
+++ b/libavfilter/vf_thumbnail_cuda.c
@@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
             hist[i] = 4 * hist[i];
     }
 
-    CHECK_CU(cu->cuCtxPopCurrent(&dummy));
+    ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
     if (ret < 0)
         return ret;
 
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it

[Timo Rothenpieler]

On 22.04.2024 03:11, Michael Niedermayer wrote:
> Fixes: CID1418336 Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavfilter/vf_thumbnail_cuda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
> index 0459070800a..8efb54f0792 100644
> --- a/libavfilter/vf_thumbnail_cuda.c
> +++ b/libavfilter/vf_thumbnail_cuda.c
> @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>               hist[i] = 4 * hist[i];
>       }
>   
> -    CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> +    ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
>       if (ret < 0)
>           return ret;
>   

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1122 bytes --]

On Mon, Apr 22, 2024 at 12:17:02PM +0200, Timo Rothenpieler wrote:
> 
> 
> On 22.04.2024 03:11, Michael Niedermayer wrote:
> > Fixes: CID1418336 Logically dead code
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >   libavfilter/vf_thumbnail_cuda.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
> > index 0459070800a..8efb54f0792 100644
> > --- a/libavfilter/vf_thumbnail_cuda.c
> > +++ b/libavfilter/vf_thumbnail_cuda.c
> > @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
> >               hist[i] = 4 * hist[i];
> >       }
> > -    CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> > +    ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> >       if (ret < 0)
> >           return ret;
> 
> LGTM

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".