* [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it
@ 2024-04-22 1:11 Michael Niedermayer
2024-04-22 10:17 ` Timo Rothenpieler
0 siblings, 1 reply; 3+ messages in thread
From: Michael Niedermayer @ 2024-04-22 1:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Fixes: CID1418336 Logically dead code
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavfilter/vf_thumbnail_cuda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
index 0459070800a..8efb54f0792 100644
--- a/libavfilter/vf_thumbnail_cuda.c
+++ b/libavfilter/vf_thumbnail_cuda.c
@@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
hist[i] = 4 * hist[i];
}
- CHECK_CU(cu->cuCtxPopCurrent(&dummy));
+ ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
if (ret < 0)
return ret;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it
2024-04-22 1:11 [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it Michael Niedermayer
@ 2024-04-22 10:17 ` Timo Rothenpieler
2024-04-22 20:48 ` Michael Niedermayer
0 siblings, 1 reply; 3+ messages in thread
From: Timo Rothenpieler @ 2024-04-22 10:17 UTC (permalink / raw)
To: ffmpeg-devel
On 22.04.2024 03:11, Michael Niedermayer wrote:
> Fixes: CID1418336 Logically dead code
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavfilter/vf_thumbnail_cuda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
> index 0459070800a..8efb54f0792 100644
> --- a/libavfilter/vf_thumbnail_cuda.c
> +++ b/libavfilter/vf_thumbnail_cuda.c
> @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
> hist[i] = 4 * hist[i];
> }
>
> - CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> + ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> if (ret < 0)
> return ret;
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it
2024-04-22 10:17 ` Timo Rothenpieler
@ 2024-04-22 20:48 ` Michael Niedermayer
0 siblings, 0 replies; 3+ messages in thread
From: Michael Niedermayer @ 2024-04-22 20:48 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1122 bytes --]
On Mon, Apr 22, 2024 at 12:17:02PM +0200, Timo Rothenpieler wrote:
>
>
> On 22.04.2024 03:11, Michael Niedermayer wrote:
> > Fixes: CID1418336 Logically dead code
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavfilter/vf_thumbnail_cuda.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
> > index 0459070800a..8efb54f0792 100644
> > --- a/libavfilter/vf_thumbnail_cuda.c
> > +++ b/libavfilter/vf_thumbnail_cuda.c
> > @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
> > hist[i] = 4 * hist[i];
> > }
> > - CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> > + ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy));
> > if (ret < 0)
> > return ret;
>
> LGTM
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 1:11 [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it Michael Niedermayer
2024-04-22 10:17 ` Timo Rothenpieler
2024-04-22 20:48 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git