From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF58C489A4 for ; Sun, 21 Apr 2024 22:19:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22FE268D27C; Mon, 22 Apr 2024 01:19:03 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C00768CAAB for ; Mon, 22 Apr 2024 01:18:56 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 99A8920008 for ; Sun, 21 Apr 2024 22:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713737935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m8JarYMfPABA4TryO+bw7cBaeGSEVnCTiEMl6No2tIU=; b=dpuz7whp8BjnsP02xDNNzKr7c3dvd308o6P87uR1zkgaqAArUY1canwzJLPkHomK0mZxLh 474vybZTHNtFNJo1RJH6+P8fnMR1zKfrgfE6Xkzg5XCP8Iuj0aH2f0R1x0SSgVZoiVdyTW Eq6QKrLwaCOGCN92LYM7IqgUlyENtXa6st6AflhMR0rjnRIK3rcocp+ErZKBu81lo26Yd1 I3anouHAZEvVJIFV9uJg4v1Kp6M333fewbf6zxuSJ72M8PHiOUkWEorcn59EEmRBOi5IEQ 0MX7jkc7MK/HxYSNSdt4rX/lK3bcv2GkvTrG1G9UzZahcSCGb8F3B2KX7vuuPg== Date: Mon, 22 Apr 2024 00:18:54 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240421221854.GA6420@pb2> References: <20240410181811.GP6420@pb2> <20240410215655.GR6420@pb2> <20240411224521.GZ6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0228281939526474650==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0228281939526474650== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GxH5FK2Q1jUm/3cK" Content-Disposition: inline --GxH5FK2Q1jUm/3cK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 12, 2024 at 11:11:53AM +0200, Lynne wrote: > Apr 12, 2024, 00:45 by michael@niedermayer.cc: >=20 > > On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: > > > >> Apr 10, 2024, 23:57 by michael@niedermayer.cc: > >> > >> > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > >> > > >> >> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > >> >> > Apr 8, 2024, 09:36 by dev@lynne.ee: > >> >> >=20 > >> >> > > The following patchset refactors the AAC decoder step by step, > >> >> > > removing all large-scale templating and abstracting away typed > >> >> > > DSP functions from symbol parsing. > >> >> > > > >> >> > > This series saves 110Kib of binary data from libavcodec.so > >> >> > > when compiled with Clang 18 with -O3, after stripping. > >> >> > > > >> >> > > The patchset can also be viewed here: > >> >> > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup > >> >> > > > >> >> > > Fate passes on each step, and I've been running this patchset f= or > >> >> > > a week with no issues. > >> >> > > > >> >> > > This also prepares the decoder for USAC support. > >> >> > > > >> >> >=20 > >> >> > I've rebased the linked repo to current git master if anyone > >> >> > wants to test. > >> >> > >> >> thanks, i will try to test it > >> >> > >> > > >> > make fate-source > >> > > >> > TEST source > >> > --- ./tests/ref/fate/source 2024-04-08 18:26:00.670129617 +0200 > >> > +++ tests/data/fate/source 2024-04-10 23:56:18.032896853 +0200 > >> > @@ -22,6 +22,13 @@ > >> > compat/djgpp/math.h > >> > compat/float/float.h > >> > compat/float/limits.h > >> > +libavcodec/aac/aacdec.h > >> > +libavcodec/aac/aacdec_fixed_coupling.h > >> > +libavcodec/aac/aacdec_fixed_dequant.h > >> > +libavcodec/aac/aacdec_fixed_prediction.h > >> > +libavcodec/aac/aacdec_float_coupling.h > >> > +libavcodec/aac/aacdec_float_prediction.h > >> > +libavcodec/aac/aacdec_latm.h > >> > libavcodec/bitstream_template.h > >> > tools/decode_simple.h > >> > Use of av_clip() where av_clip_uintp2() could be used: > >> > Test source failed. Look at tests/data/fate/source.err for details. > >> > tests/Makefile:310: recipe for target 'fate-source' failed > >> > make: *** [fate-source] Error 1 > >> > > >> > >> Thanks for testing. Fixed both issues in the repo. > >> Was only testing with fate-aac while developing. > >> > > > > mips: > > > > make -k > > LD ffmpeg_g > > libavcodec/libavcodec.a(aacsbr.o): In function `ff_aac_sbr_ctx_alloc_in= it': > > aacsbr.c:(.text.unlikely+0x1d4): undefined reference to `ff_aacsbr_func= _ptr_init_mips' > > aacsbr.c:(.text.unlikely+0x200): undefined reference to `ff_aacsbr_func= _ptr_init_mips' > > libavcodec/libavcodec.a(sbrdsp.o): In function `ff_sbrdsp_init': > > sbrdsp.c:(.text.unlikely+0x10): undefined reference to `ff_sbrdsp_init_= mips' > > sbrdsp.c:(.text.unlikely+0xb4): undefined reference to `ff_sbrdsp_init_= mips' > > libavcodec/libavcodec.a(aacpsdsp_float.o): In function `ff_psdsp_init': > > aacpsdsp_float.c:(.text.unlikely+0x10): undefined reference to `ff_psds= p_init_mips' > > aacpsdsp_float.c:(.text.unlikely+0x6c): undefined reference to `ff_psds= p_init_mips' > > collect2: error: ld returned 1 exit status > > Makefile:136: recipe for target 'ffmpeg_g' failed > > make: *** [ffmpeg_g] Error 1 > > LD ffprobe_g > > libavcodec/libavcodec.a(aacsbr.o): In function `ff_aac_sbr_ctx_alloc_in= it': > > aacsbr.c:(.text.unlikely+0x1d4): undefined reference to `ff_aacsbr_func= _ptr_init_mips' > > aacsbr.c:(.text.unlikely+0x200): undefined reference to `ff_aacsbr_func= _ptr_init_mips' > > libavcodec/libavcodec.a(sbrdsp.o): In function `ff_sbrdsp_init': > > sbrdsp.c:(.text.unlikely+0x10): undefined reference to `ff_sbrdsp_init_= mips' > > sbrdsp.c:(.text.unlikely+0xb4): undefined reference to `ff_sbrdsp_init_= mips' > > libavcodec/libavcodec.a(aacpsdsp_float.o): In function `ff_psdsp_init': > > aacpsdsp_float.c:(.text.unlikely+0x10): undefined reference to `ff_psds= p_init_mips' > > aacpsdsp_float.c:(.text.unlikely+0x6c): undefined reference to `ff_psds= p_init_mips' > > collect2: error: ld returned 1 exit status > > Makefile:136: recipe for target 'ffprobe_g' failed > > make: *** [ffprobe_g] Error 1 > > make: Target 'all' not remade because of errors. > > >=20 > Fixed. This should be all. > On the Loongson machine I have access to, I can't compile FFmpeg > due to missing asm/errno.h kernel header, while on the standard MIPS64 > machine I can access, compilation worked either way. > Would you mind testing again the new version in the repo? it works on my qemu based mips. I did give the loongson to anton 2 years ago so i have no native loongson to test it with thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --GxH5FK2Q1jUm/3cK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZiWQygAKCRBhHseHBAsP qwGWAJ4jfZsgSiPs7b1qDzjoVWIrgyYBnACfbCplI9z6LFdXUNLaTB8Okmzhrpw= =7tb3 -----END PGP SIGNATURE----- --GxH5FK2Q1jUm/3cK-- --===============0228281939526474650== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0228281939526474650==--