* [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe
[not found] <CGME20240417052305eucas1p100098206998d263abc1031a7fcdf6669@eucas1p1.samsung.com>
@ 2024-04-17 5:22 ` Dawid Kozinski
2024-04-17 12:38 ` James Almer
0 siblings, 1 reply; 4+ messages in thread
From: Dawid Kozinski @ 2024-04-17 5:22 UTC (permalink / raw)
To: d.frankiewic, ffmpeg-devel; +Cc: Dawid Kozinski
Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
---
libavcodec/libxevd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
index c6c7327e65..e864bd5200 100644
--- a/libavcodec/libxevd.c
+++ b/libavcodec/libxevd.c
@@ -391,6 +391,11 @@ static int libxevd_receive_frame(AVCodecContext *avctx, AVFrame *frame)
if (stat.read != nalu_size)
av_log(avctx, AV_LOG_INFO, "Different reading of bitstream (in:%d, read:%d)\n,", nalu_size, stat.read);
+ if (stat.stype == XEVD_ST_I) {
+ frame->pict_type = AV_PICTURE_TYPE_I;
+ frame->flags |= AV_FRAME_FLAG_KEY;
+ }
+
// stat.fnum - has negative value if the decoded data is not frame
if (stat.fnum >= 0) {
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe
2024-04-17 5:22 ` [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe Dawid Kozinski
@ 2024-04-17 12:38 ` James Almer
2024-04-18 7:34 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-05-06 7:12 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
0 siblings, 2 replies; 4+ messages in thread
From: James Almer @ 2024-04-17 12:38 UTC (permalink / raw)
To: ffmpeg-devel
On 4/17/2024 2:22 AM, Dawid Kozinski wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
> libavcodec/libxevd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c
> index c6c7327e65..e864bd5200 100644
> --- a/libavcodec/libxevd.c
> +++ b/libavcodec/libxevd.c
> @@ -391,6 +391,11 @@ static int libxevd_receive_frame(AVCodecContext *avctx, AVFrame *frame)
> if (stat.read != nalu_size)
> av_log(avctx, AV_LOG_INFO, "Different reading of bitstream (in:%d, read:%d)\n,", nalu_size, stat.read);
>
> + if (stat.stype == XEVD_ST_I) {
> + frame->pict_type = AV_PICTURE_TYPE_I;
> + frame->flags |= AV_FRAME_FLAG_KEY;
> + }
Shouldn't this be inside the stat.fnum >= 0 block below?
> +
> // stat.fnum - has negative value if the decoded data is not frame
> if (stat.fnum >= 0) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe
2024-04-17 12:38 ` James Almer
@ 2024-04-18 7:34 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-05-06 7:12 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
1 sibling, 0 replies; 4+ messages in thread
From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2024-04-18 7:34 UTC (permalink / raw)
To: 'FFmpeg development discussions and patches'
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James
> Almer
> Sent: środa, 17 kwietnia 2024 14:39
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the
> AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet
> contains a keyframe
>
> On 4/17/2024 2:22 AM, Dawid Kozinski wrote:
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > ---
> > libavcodec/libxevd.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> > c6c7327e65..e864bd5200 100644
> > --- a/libavcodec/libxevd.c
> > +++ b/libavcodec/libxevd.c
> > @@ -391,6 +391,11 @@ static int libxevd_receive_frame(AVCodecContext
> *avctx, AVFrame *frame)
> > if (stat.read != nalu_size)
> > av_log(avctx, AV_LOG_INFO, "Different reading of
> > bitstream (in:%d, read:%d)\n,", nalu_size, stat.read);
> >
> > + if (stat.stype == XEVD_ST_I) {
> > + frame->pict_type = AV_PICTURE_TYPE_I;
> > + frame->flags |= AV_FRAME_FLAG_KEY;
> > + }
>
> Shouldn't this be inside the stat.fnum >= 0 block below?
You're right. I will move it.
>
> > +
> > // stat.fnum - has negative value if the decoded data is
not frame
> > if (stat.fnum >= 0) {
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=a29889eb-c3139cd2-a29902a4-
> 000babffae10-eb1fef97e1007353&q=1&e=c04d8490-c1e2-4395-83d3-
> 7ea762e16a64&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe
2024-04-17 12:38 ` James Almer
2024-04-18 7:34 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
@ 2024-05-06 7:12 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
1 sibling, 0 replies; 4+ messages in thread
From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2024-05-06 7:12 UTC (permalink / raw)
To: 'FFmpeg development discussions and patches'
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James
> Almer
> Sent: środa, 17 kwietnia 2024 14:39
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the
> AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet
> contains a keyframe
>
> On 4/17/2024 2:22 AM, Dawid Kozinski wrote:
> > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > ---
> > libavcodec/libxevd.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c index
> > c6c7327e65..e864bd5200 100644
> > --- a/libavcodec/libxevd.c
> > +++ b/libavcodec/libxevd.c
> > @@ -391,6 +391,11 @@ static int libxevd_receive_frame(AVCodecContext
> *avctx, AVFrame *frame)
> > if (stat.read != nalu_size)
> > av_log(avctx, AV_LOG_INFO, "Different reading of
> > bitstream (in:%d, read:%d)\n,", nalu_size, stat.read);
> >
> > + if (stat.stype == XEVD_ST_I) {
> > + frame->pict_type = AV_PICTURE_TYPE_I;
> > + frame->flags |= AV_FRAME_FLAG_KEY;
> > + }
>
> Shouldn't this be inside the stat.fnum >= 0 block below?
>
> > +
> > // stat.fnum - has negative value if the decoded data is
not frame
> > if (stat.fnum >= 0) {
Moved
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://protect2.fireeye.com/v1/url?k=a29889eb-c3139cd2-a29902a4-
> 000babffae10-eb1fef97e1007353&q=1&e=c04d8490-c1e2-4395-83d3-
> 7ea762e16a64&u=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmp
> eg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-06 7:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20240417052305eucas1p100098206998d263abc1031a7fcdf6669@eucas1p1.samsung.com>
2024-04-17 5:22 ` [FFmpeg-devel] [PATCH v1 1/6] avcodec/evc: Set the AV_FRAME_FLAG_KEY flag for a decoded frame when the decoded packet contains a keyframe Dawid Kozinski
2024-04-17 12:38 ` James Almer
2024-04-18 7:34 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2024-05-06 7:12 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git