From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C1FC549682 for ; Tue, 16 Apr 2024 20:46:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5770E68D250; Tue, 16 Apr 2024 23:46:29 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 743E668CD94 for ; Tue, 16 Apr 2024 23:46:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C85A51C0003 for ; Tue, 16 Apr 2024 20:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713300383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HWdNwKo402+wV+fBSZASKGQt9EEAt5T115OlqDM2fhs=; b=SkKleo4n/U/Uauiqrw8JV4CPL16A3A1G0woD0FS+41wuNt71GVwgST79NbRXs8cRGMYEhI lOsnPv2zT7r76bG9YwQxThlJYXAUWzRJCd/iIIDb5Y+CJXR8gps5CUf+1WXwaln/sgGrR6 jCoKVEFFL266PBCmWPr0F35tSzo/rNVXCy6reUAy8g+ypv9LD7xQHb7rJT+NVM6nd76Yoh gezSWMgYEccU5V91NaxLjDB4osc9RNPpv3j4v2SVY+8RQN+6WPfYkKPrVN37Ye2tHImYLy M4nVFfLcGV6WpAR3h3ygNtPbz8udCRPwFVraQ+4/vWQJmf6z8JvEoZmHP+3utA== Date: Tue, 16 Apr 2024 22:46:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240416204621.GG6420@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] opusdsp: add ability to modify deemphasis constant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2653157272159508650==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2653157272159508650== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B7wRR8X3zvz2KzEZ" Content-Disposition: inline --B7wRR8X3zvz2KzEZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 15, 2024 at 08:28:30AM +0200, Lynne wrote: > xHE-AAC relies on the same postfilter mechanism > that Opus uses to improve clarity (albeit with a steeper > deemphasis filter, using a z=3D0.64). >=20 > The code to apply it is identical, it's still just a > simple IIR low-pass filter. This commit makes it possible > to use alternative constants. >=20 > Patch attached. >=20 > aarch64/opusdsp_init.c | 2 +- > aarch64/opusdsp_neon.S | 28 +++++----------------------- > opusdec_celt.c | 4 +++- > opusdsp.c | 28 ++++++++++++++++++++++++++-- > opusdsp.h | 2 +- > x86/opusdsp.asm | 9 +++------ > x86/opusdsp_init.c | 2 +- > 7 files changed, 40 insertions(+), 35 deletions(-) > 4a533c8a664bd6f0d0dac3775e4bd94050bd0532 0001-opusdsp-add-ability-to-mod= ify-deemphasis-constant.patch > From c4ad107076970a555ed838a75c0343dffe0cad36 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Mon, 29 Jan 2024 04:31:43 +0100 > Subject: [PATCH] opusdsp: add ability to modify deemphasis constant seems missing some header entry or other patch libavcodec/opusdec_celt.c: In function =E2=80=98ff_celt_decode_frame=E2=80= =99: libavcodec/opusdec_celt.c:464:51: error: =E2=80=98ff_deemph_opus_weights=E2= =80=99 undeclared (first use in this function) 464 | ff_deemph_opus_we= ights, | ^~~~~~~~~~~~~~~~~= ~~~~~ libavcodec/opusdec_celt.c:464:51: note: each undeclared identifier is repor= ted only once for each function it appears in make: *** [ffbuild/common.mak:81: libavcodec/opusdec_celt.o] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --B7wRR8X3zvz2KzEZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZh7jlAAKCRBhHseHBAsP q1bqAJ92BMUxgu3CFWTIzt5OSs90XPXzrACbBGuuiX1NiK4WTCc64GulychuLvM= =Oc9H -----END PGP SIGNATURE----- --B7wRR8X3zvz2KzEZ-- --===============2653157272159508650== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2653157272159508650==--