Re: [FFmpeg-devel] [PATCH] opusdsp: add ability to modify deemphasis constant

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] opusdsp: add ability to modify deemphasis constant
Date: Tue, 16 Apr 2024 22:46:21 +0200
Message-ID: <20240416204621.GG6420@pb2> (raw)
In-Reply-To: <NvVRKuK--3-9@lynne.ee>

[-- Attachment #1.1: Type: text/plain, Size: 1961 bytes --]

On Mon, Apr 15, 2024 at 08:28:30AM +0200, Lynne wrote:
> xHE-AAC relies on the same postfilter mechanism
> that Opus uses to improve clarity (albeit with a steeper
> deemphasis filter, using a z=0.64).
> 
> The code to apply it is identical, it's still just a
> simple IIR low-pass filter. This commit makes it possible
> to use alternative constants.
> 
> Patch attached.
> 

>  aarch64/opusdsp_init.c |    2 +-
>  aarch64/opusdsp_neon.S |   28 +++++-----------------------
>  opusdec_celt.c         |    4 +++-
>  opusdsp.c              |   28 ++++++++++++++++++++++++++--
>  opusdsp.h              |    2 +-
>  x86/opusdsp.asm        |    9 +++------
>  x86/opusdsp_init.c     |    2 +-
>  7 files changed, 40 insertions(+), 35 deletions(-)
> 4a533c8a664bd6f0d0dac3775e4bd94050bd0532  0001-opusdsp-add-ability-to-modify-deemphasis-constant.patch
> From c4ad107076970a555ed838a75c0343dffe0cad36 Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Mon, 29 Jan 2024 04:31:43 +0100
> Subject: [PATCH] opusdsp: add ability to modify deemphasis constant

seems missing some header entry or other patch

libavcodec/opusdec_celt.c: In function ‘ff_celt_decode_frame’:
libavcodec/opusdec_celt.c:464:51: error: ‘ff_deemph_opus_weights’ undeclared (first use in this function)
  464 |                                                   ff_deemph_opus_weights,
      |                                                   ^~~~~~~~~~~~~~~~~~~~~~
libavcodec/opusdec_celt.c:464:51: note: each undeclared identifier is reported only once for each function it appears in
make: *** [ffbuild/common.mak:81: libavcodec/opusdec_celt.o] Error 1

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".