From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A5554945A for ; Thu, 11 Apr 2024 22:45:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0831768CEB0; Fri, 12 Apr 2024 01:45:30 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6FF6E68CB0D for ; Fri, 12 Apr 2024 01:45:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9A7AB1BF203 for ; Thu, 11 Apr 2024 22:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712875522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiWPnuq7AE01nh4nRSW3MlWDBHrsbyxVOphHGqnA3Ls=; b=S0amkWWCUOlbXZ5qRK7l1mNZxH+xNCoSVCMH3nnGFJzI65EHHkAYbCJWvfeHs3OouIO7mC OMdZvPrPmNG0bJmKGfBuSdTGHZ0PIkgi+WpTRbMiObuERIBQfJenm93Uaz2Cn0D+J+Xl7r hw8/28s5HQ/3GDFR9Btg4wtu8Zy6dh3NnmpLHBCXmwrK6akRi5WWVpGtyJzQ3ue+cBT20T gWAz4hQVfHFQde1GRJcyk4PPfF0BN3XMdjiS0Wh0go1SjTs8U/8eZ/AxXmpisGC1gsQGzs 4whpbyV8vo5trWvCkXlD9GvhU78/7YWjzKfF2F+EgMNKV1VQfY8AV1vDRKUljg== Date: Fri, 12 Apr 2024 00:45:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240411224521.GZ6420@pb2> References: <20240410181811.GP6420@pb2> <20240410215655.GR6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7817837801047972625==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7817837801047972625== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qm4B7iue+6mWov2J" Content-Disposition: inline --qm4B7iue+6mWov2J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: > Apr 10, 2024, 23:57 by michael@niedermayer.cc: >=20 > > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > > > >> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > >> > Apr 8, 2024, 09:36 by dev@lynne.ee: > >> >=20 > >> > > The following patchset refactors the AAC decoder step by step, > >> > > removing all large-scale templating and abstracting away typed > >> > > DSP functions from symbol parsing. > >> > > > >> > > This series saves 110Kib of binary data from libavcodec.so > >> > > when compiled with Clang 18 with -O3, after stripping. > >> > > > >> > > The patchset can also be viewed here: > >> > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup > >> > > > >> > > Fate passes on each step, and I've been running this patchset for > >> > > a week with no issues. > >> > > > >> > > This also prepares the decoder for USAC support. > >> > > > >> >=20 > >> > I've rebased the linked repo to current git master if anyone > >> > wants to test. > >> > >> thanks, i will try to test it > >> > > > > make fate-source > > > > TEST source > > --- ./tests/ref/fate/source 2024-04-08 18:26:00.670129617 +0200 > > +++ tests/data/fate/source 2024-04-10 23:56:18.032896853 +0200 > > @@ -22,6 +22,13 @@ > > compat/djgpp/math.h > > compat/float/float.h > > compat/float/limits.h > > +libavcodec/aac/aacdec.h > > +libavcodec/aac/aacdec_fixed_coupling.h > > +libavcodec/aac/aacdec_fixed_dequant.h > > +libavcodec/aac/aacdec_fixed_prediction.h > > +libavcodec/aac/aacdec_float_coupling.h > > +libavcodec/aac/aacdec_float_prediction.h > > +libavcodec/aac/aacdec_latm.h > > libavcodec/bitstream_template.h > > tools/decode_simple.h > > Use of av_clip() where av_clip_uintp2() could be used: > > Test source failed. Look at tests/data/fate/source.err for details. > > tests/Makefile:310: recipe for target 'fate-source' failed > > make: *** [fate-source] Error 1 > > >=20 > Thanks for testing. Fixed both issues in the repo. > Was only testing with fate-aac while developing. mips: make -k LD ffmpeg_g libavcodec/libavcodec.a(aacsbr.o): In function `ff_aac_sbr_ctx_alloc_init': aacsbr.c:(.text.unlikely+0x1d4): undefined reference to `ff_aacsbr_func_ptr= _init_mips' aacsbr.c:(.text.unlikely+0x200): undefined reference to `ff_aacsbr_func_ptr= _init_mips' libavcodec/libavcodec.a(sbrdsp.o): In function `ff_sbrdsp_init': sbrdsp.c:(.text.unlikely+0x10): undefined reference to `ff_sbrdsp_init_mips' sbrdsp.c:(.text.unlikely+0xb4): undefined reference to `ff_sbrdsp_init_mips' libavcodec/libavcodec.a(aacpsdsp_float.o): In function `ff_psdsp_init': aacpsdsp_float.c:(.text.unlikely+0x10): undefined reference to `ff_psdsp_in= it_mips' aacpsdsp_float.c:(.text.unlikely+0x6c): undefined reference to `ff_psdsp_in= it_mips' collect2: error: ld returned 1 exit status Makefile:136: recipe for target 'ffmpeg_g' failed make: *** [ffmpeg_g] Error 1 LD ffprobe_g libavcodec/libavcodec.a(aacsbr.o): In function `ff_aac_sbr_ctx_alloc_init': aacsbr.c:(.text.unlikely+0x1d4): undefined reference to `ff_aacsbr_func_ptr= _init_mips' aacsbr.c:(.text.unlikely+0x200): undefined reference to `ff_aacsbr_func_ptr= _init_mips' libavcodec/libavcodec.a(sbrdsp.o): In function `ff_sbrdsp_init': sbrdsp.c:(.text.unlikely+0x10): undefined reference to `ff_sbrdsp_init_mips' sbrdsp.c:(.text.unlikely+0xb4): undefined reference to `ff_sbrdsp_init_mips' libavcodec/libavcodec.a(aacpsdsp_float.o): In function `ff_psdsp_init': aacpsdsp_float.c:(.text.unlikely+0x10): undefined reference to `ff_psdsp_in= it_mips' aacpsdsp_float.c:(.text.unlikely+0x6c): undefined reference to `ff_psdsp_in= it_mips' collect2: error: ld returned 1 exit status Makefile:136: recipe for target 'ffprobe_g' failed make: *** [ffprobe_g] Error 1 make: Target 'all' not remade because of errors. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --qm4B7iue+6mWov2J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZhhn/gAKCRBhHseHBAsP qwuyAJ9Ioe2/S3VpNijHzzAE4y8a+F9chQCeMJPHqTJhM8ZCqmj1WQ8qmT906+s= =paLD -----END PGP SIGNATURE----- --qm4B7iue+6mWov2J-- --===============7817837801047972625== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7817837801047972625==--