* [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
@ 2024-04-11 15:42 James Almer
2024-04-11 20:17 ` Kieran Kunhya
0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2024-04-11 15:42 UTC (permalink / raw)
To: ffmpeg-devel
Some interlaced h264 samples may export one caption per field.
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavutil/frame.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index 0775e2abd9..fdac6f8ee2 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -30,7 +30,6 @@
static const AVSideDataDescriptor sd_props[] = {
[AV_FRAME_DATA_PANSCAN] = { "AVPanScan" },
- [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions" },
[AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" },
[AV_FRAME_DATA_DOWNMIX_INFO] = { "Metadata relevant to a downmix procedure" },
[AV_FRAME_DATA_AFD] = { "Active format description" },
@@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = {
[AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing environment", AV_SIDE_DATA_PROP_GLOBAL },
[AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping", AV_SIDE_DATA_PROP_GLOBAL },
[AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile", AV_SIDE_DATA_PROP_GLOBAL },
+ [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4 Closed Captions", AV_SIDE_DATA_PROP_MULTI },
[AV_FRAME_DATA_SEI_UNREGISTERED] = { "H.26[45] User Data Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI },
};
--
2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
2024-04-11 15:42 [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries James Almer
@ 2024-04-11 20:17 ` Kieran Kunhya
2024-04-11 21:07 ` James Almer
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Kunhya @ 2024-04-11 20:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, 11 Apr 2024, 16:42 James Almer, <jamrial@gmail.com> wrote:
> Some interlaced h264 samples may export one caption per field.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/frame.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index 0775e2abd9..fdac6f8ee2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -30,7 +30,6 @@
>
> static const AVSideDataDescriptor sd_props[] = {
> [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" },
> - [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
> Closed Captions" },
> [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" },
> [AV_FRAME_DATA_DOWNMIX_INFO] = { "Metadata relevant to
> a downmix procedure" },
> [AV_FRAME_DATA_AFD] = { "Active format
> description" },
> @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = {
> [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing
> environment", AV_SIDE_DATA_PROP_GLOBAL },
> [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping",
> AV_SIDE_DATA_PROP_GLOBAL },
> [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile",
> AV_SIDE_DATA_PROP_GLOBAL },
> + [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
> Closed Captions", AV_SIDE_DATA_PROP_MULTI },
> [AV_FRAME_DATA_SEI_UNREGISTERED] = { "H.26[45] User Data
> Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI },
> };
>
> --
> 2.44.0
>
But we merge the captions into a single side data element, no?
Kieran
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
2024-04-11 20:17 ` Kieran Kunhya
@ 2024-04-11 21:07 ` James Almer
0 siblings, 0 replies; 3+ messages in thread
From: James Almer @ 2024-04-11 21:07 UTC (permalink / raw)
To: ffmpeg-devel
On 4/11/2024 5:17 PM, Kieran Kunhya wrote:
> On Thu, 11 Apr 2024, 16:42 James Almer, <jamrial@gmail.com> wrote:
>
>> Some interlaced h264 samples may export one caption per field.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavutil/frame.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavutil/frame.c b/libavutil/frame.c
>> index 0775e2abd9..fdac6f8ee2 100644
>> --- a/libavutil/frame.c
>> +++ b/libavutil/frame.c
>> @@ -30,7 +30,6 @@
>>
>> static const AVSideDataDescriptor sd_props[] = {
>> [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" },
>> - [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
>> Closed Captions" },
>> [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" },
>> [AV_FRAME_DATA_DOWNMIX_INFO] = { "Metadata relevant to
>> a downmix procedure" },
>> [AV_FRAME_DATA_AFD] = { "Active format
>> description" },
>> @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = {
>> [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing
>> environment", AV_SIDE_DATA_PROP_GLOBAL },
>> [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping",
>> AV_SIDE_DATA_PROP_GLOBAL },
>> [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile",
>> AV_SIDE_DATA_PROP_GLOBAL },
>> + [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
>> Closed Captions", AV_SIDE_DATA_PROP_MULTI },
>> [AV_FRAME_DATA_SEI_UNREGISTERED] = { "H.26[45] User Data
>> Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI },
>> };
>>
>> --
>> 2.44.0
>>
>
> But we merge the captions into a single side data element, no?
>
> Kieran
Oh, I must have misread how it was exported. Dropping this patch then.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-11 21:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-11 15:42 [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries James Almer
2024-04-11 20:17 ` Kieran Kunhya
2024-04-11 21:07 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git