From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B3AD49DC3 for ; Wed, 10 Apr 2024 21:57:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A794968D0B7; Thu, 11 Apr 2024 00:57:02 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 45A2F68C95A for ; Thu, 11 Apr 2024 00:56:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6CBD2E0002 for ; Wed, 10 Apr 2024 21:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712786216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yT5/1MidGHWZxHfso4+iqcct8LEKnrzuC/SeVYmxd3c=; b=C+LZP/0H/1qFgNAr4t2/E7L+p9+aZpsMSf3K9EhNx4dgOwyKhDSmWZHVCQ2aJttGJj/ifV y5/rtuujkYB/SyXd8rjT8iN6kN703pmYRkHCaHpPbhe0TX9+nkm6p472FKEIMkTMgOE709 AI+ujcTRHuxhHuEpJ9N2K2o9PzENPKFxAYHjm2GH4Dbh1+JjWPF9iDVxgIA430L3Cj9iYO uV2TshlOKAn5ZHGcBUP35+vWOSVoa5u/XMlRi4Nssh/3uAJij51htMajw7L+o0176j06gX q/RSXP1VQOvjVoBJhNn+d9cvpOkOfqXTCT0SHEPKla4DPze7FL9w+jfJhSozQA== Date: Wed, 10 Apr 2024 23:56:55 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240410215655.GR6420@pb2> References: <20240410181811.GP6420@pb2> MIME-Version: 1.0 In-Reply-To: <20240410181811.GP6420@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7475052865598554669==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7475052865598554669== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="933eN3nRvGIHl/bc" Content-Disposition: inline --933eN3nRvGIHl/bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > > Apr 8, 2024, 09:36 by dev@lynne.ee: > >=20 > > > The following patchset refactors the AAC decoder step by step, > > > removing all large-scale templating and abstracting away typed > > > DSP functions from symbol parsing. > > > > > > This series saves 110Kib of binary data from libavcodec.so > > > when compiled with Clang 18 with -O3, after stripping. > > > > > > The patchset can also be viewed here: > > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup > > > > > > Fate passes on each step, and I've been running this patchset for > > > a week with no issues. > > > > > > This also prepares the decoder for USAC support. > > > > >=20 > > I've rebased the linked repo to current git master if anyone > > wants to test. >=20 > thanks, i will try to test it make fate-source TEST source --- ./tests/ref/fate/source 2024-04-08 18:26:00.670129617 +0200 +++ tests/data/fate/source 2024-04-10 23:56:18.032896853 +0200 @@ -22,6 +22,13 @@ compat/djgpp/math.h compat/float/float.h compat/float/limits.h +libavcodec/aac/aacdec.h +libavcodec/aac/aacdec_fixed_coupling.h +libavcodec/aac/aacdec_fixed_dequant.h +libavcodec/aac/aacdec_fixed_prediction.h +libavcodec/aac/aacdec_float_coupling.h +libavcodec/aac/aacdec_float_prediction.h +libavcodec/aac/aacdec_latm.h libavcodec/bitstream_template.h tools/decode_simple.h Use of av_clip() where av_clip_uintp2() could be used: Test source failed. Look at tests/data/fate/source.err for details. tests/Makefile:310: recipe for target 'fate-source' failed make: *** [fate-source] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who breaks a law that conscience tells him is unjust and willingly= =20 accepts the penalty by staying in jail in order to arouse the conscience of= =20 the community on the injustice of the law is at that moment expressing the= =20 very highest respect for law. - Martin Luther King Jr --933eN3nRvGIHl/bc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iFwEABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZhcLJwAKCRBhHseHBAsP qyZYAKCavDy6pyrpyGjvrisynIzPRg4HhwCYrNhJdgGOcOCgMxbFxNfw0O0nWQ== =TmIz -----END PGP SIGNATURE----- --933eN3nRvGIHl/bc-- --===============7475052865598554669== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7475052865598554669==--