From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0788A49DBE for ; Wed, 10 Apr 2024 21:51:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1590F68D0B1; Thu, 11 Apr 2024 00:51:09 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42D7C68C496 for ; Thu, 11 Apr 2024 00:51:02 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8F8BF40004 for ; Wed, 10 Apr 2024 21:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712785861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rf5bW/TeOB3lVQ6zfHpwIR8fb9n190cmVhqK08f2Xs0=; b=mXKa3fod5zC07QidlQTolbulc/AUDqQ3yxWyswFpialz0wJe/zlS4XPh7ekMTGJxGD2mUb 4RjybhBV44vJpCRFjHuz3HuTzdghzTz5oSVcHfZFoOtaT8TB8cnXT2tcGC+Ha5HE/JZ1Fn v9Bgyn+I2RSIltCY2QD8MXCrJJQTrodDLReDy0YD+3VF7CnXk2q182tdEpDJ4bRnKzWh1e aYp+TVNvdwPuBspV5CErFAHzWW/A83UtYmbPl3NYO8QKLT1HSGaaAJ1OCAnliLQOO0r8Zy hPgnHKOwUGCH+9YM+e1PnUfz6rBKxpQ98KkMZA49lqOtBQWB8UK9e082FC3jag== Date: Wed, 10 Apr 2024 23:51:00 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240410215100.GQ6420@pb2> References: <20240410181811.GP6420@pb2> MIME-Version: 1.0 In-Reply-To: <20240410181811.GP6420@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8629553243608921075==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8629553243608921075== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NXS/d8+8gWdBR9HS" Content-Disposition: inline --NXS/d8+8gWdBR9HS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: > On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote: > > Apr 8, 2024, 09:36 by dev@lynne.ee: > >=20 > > > The following patchset refactors the AAC decoder step by step, > > > removing all large-scale templating and abstracting away typed > > > DSP functions from symbol parsing. > > > > > > This series saves 110Kib of binary data from libavcodec.so > > > when compiled with Clang 18 with -O3, after stripping. > > > > > > The patchset can also be viewed here: > > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup > > > > > > Fate passes on each step, and I've been running this patchset for > > > a week with no issues. > > > > > > This also prepares the decoder for USAC support. > > > > >=20 > > I've rebased the linked repo to current git master if anyone > > wants to test. >=20 > thanks, i will try to test it build fails on mips make -j32 -k CC libavcodec/aac/aacdec_float.o src/libavcodec/aac/aacdec_float.c: In function =E2=80=98init=E2=80=99: src/libavcodec/aac/aacdec_float.c:81:5: error: implicit declaration of func= tion =E2=80=98ff_aacdec_init_mips=E2=80=99; did you mean =E2=80=98ff_float_= dsp_init_mips=E2=80=99? [-Werror=3Dimplicit-function-declaration] ff_aacdec_init_mips(ac); ^~~~~~~~~~~~~~~~~~~ ff_float_dsp_init_mips cc1: some warnings being treated as errors src/ffbuild/common.mak:81: recipe for target 'libavcodec/aac/aacdec_float.o= ' failed make: *** [libavcodec/aac/aacdec_float.o] Error 1 make: Target 'all' not remade because of errors. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --NXS/d8+8gWdBR9HS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZhcJvgAKCRBhHseHBAsP qxH6AJ9nv8LXd3k6wHSLSA70kmVrP/HRGQCfdGH7yEh6hw+6fjZjUHa5MQ5ZbXM= =ejAu -----END PGP SIGNATURE----- --NXS/d8+8gWdBR9HS-- --===============8629553243608921075== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8629553243608921075==--