Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1819 bytes --]

On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote:
> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote:
> > Apr 8, 2024, 09:36 by dev@lynne.ee:
> > 
> > > The following patchset refactors the AAC decoder step by step,
> > > removing all large-scale templating and abstracting away typed
> > > DSP functions from symbol parsing.
> > >
> > > This series saves 110Kib of binary data from libavcodec.so
> > > when compiled with Clang 18 with -O3, after stripping.
> > >
> > > The patchset can also be viewed here:
> > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup
> > >
> > > Fate passes on each step, and I've been running this patchset for
> > > a week with no issues.
> > >
> > > This also prepares the decoder for USAC support.
> > >
> > 
> > I've rebased the linked repo to current git master if anyone
> > wants to test.
> 
> thanks, i will try to test it

build fails on mips

make -j32 -k
CC	libavcodec/aac/aacdec_float.o
src/libavcodec/aac/aacdec_float.c: In function ‘init’:
src/libavcodec/aac/aacdec_float.c:81:5: error: implicit declaration of function ‘ff_aacdec_init_mips’; did you mean ‘ff_float_dsp_init_mips’? [-Werror=implicit-function-declaration]
     ff_aacdec_init_mips(ac);
     ^~~~~~~~~~~~~~~~~~~
     ff_float_dsp_init_mips
cc1: some warnings being treated as errors
src/ffbuild/common.mak:81: recipe for target 'libavcodec/aac/aacdec_float.o' failed
make: *** [libavcodec/aac/aacdec_float.o] Error 1
make: Target 'all' not remade because of errors.



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".