From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B38E74A7C6 for ; Tue, 9 Apr 2024 13:01:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8839D68D12E; Tue, 9 Apr 2024 16:01:05 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E17AE68D0F6 for ; Tue, 9 Apr 2024 16:00:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1712667659; bh=rav9nursC9kkBhCavPqTmyXFwmLDy1zK5CgilV7lpeg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lgkwPEOGc3Pmd89Pg6zAb+nnaom/SIgG1djx2kK9QCWY6i6rc3pyLZsBUDFgeimBa YrjzExmIPxwe3zNtSvbwXrbIFup/4TkGwgjjTWK3EpQBUBTNMw01DOOtNeUIy6ZkkL E+vzDVA4gVDrTudcQdmjwASmMnwEcN3GruzVt25o= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id B78D340006; Tue, 9 Apr 2024 15:00:59 +0200 (CEST) Date: Tue, 9 Apr 2024 15:00:59 +0200 Message-ID: <20240409150059.GB62311@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240408125950.53472-10-ffmpeg@haasn.xyz> References: <20240408125950.53472-1-ffmpeg@haasn.xyz> <20240408125950.53472-10-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2 09/17] avcodec/codec_internal: nuke init_static_data() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 08 Apr 2024 14:57:13 +0200 Niklas Haas wrote: > From: Niklas Haas > > All hail get_supported_config() > --- > libavcodec/allcodecs.c | 7 +------ > libavcodec/codec_internal.h | 8 -------- > 2 files changed, 1 insertion(+), 14 deletions(-) > > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > index a9f1797930a..1f22e06e710 100644 > --- a/libavcodec/allcodecs.c > +++ b/libavcodec/allcodecs.c > @@ -916,13 +916,8 @@ static AVOnce av_codec_static_init = AV_ONCE_INIT; > static void av_codec_init_static(void) > { > for (int i = 0; codec_list[i]; i++) { > - const FFCodec *codec = codec_list[i]; > - if (codec->init_static_data) { > - codec->init_static_data((FFCodec*) codec); > - continue; > - } > - > /* Backward compatibility with deprecated public fields */ > + const FFCodec *codec = codec_list[i]; > if (!codec->get_supported_config) > continue; > > diff --git a/libavcodec/codec_internal.h b/libavcodec/codec_internal.h > index bac3e30ba2c..d3033db3375 100644 > --- a/libavcodec/codec_internal.h > +++ b/libavcodec/codec_internal.h > @@ -174,14 +174,6 @@ typedef struct FFCodec { > */ > const FFCodecDefault *defaults; > > - /** > - * Initialize codec static data, called from av_codec_iterate(). > - * > - * This is not intended for time consuming operations as it is > - * run for every codec regardless of that codec being used. > - */ > - void (*init_static_data)(struct FFCodec *codec); > - > int (*init)(struct AVCodecContext *); > > union { > -- > 2.44.0 > Note: This depends on my other series for dropping init_static_data from libx264. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".