From: "J. Dekker" <jdek@itanimul.li> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v3 1/5] configure: simplify bigendian check Date: Tue, 9 Apr 2024 15:50:30 +0200 Message-ID: <20240409135034.95513-1-jdek@itanimul.li> (raw) The preferred way to use LTO is --enable-lto but often times packagers still end up with -flto in cflags for various reasons. Using grep on binary object files is brittle and relies on specific object representation, which in the case of LLVM bitcode, debug information or other intermediary formats can fail silently. This patch changes the check to a more commonly used define for GCC style compilers. More checks may be needed to cover other potential compilers that don't use the __BYTE_ORDER__ define. Signed-off-by: J. Dekker <jdek@itanimul.li> --- configure | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b/configure index f511fbae49..7c22772485 100755 --- a/configure +++ b/configure @@ -6120,11 +6120,7 @@ extern_prefix=${sym%%ff_extern*} check_cc pragma_deprecated "" '_Pragma("GCC diagnostic push") _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")' -# The global variable ensures the bits appear unchanged in the object file. -test_cc <<EOF || die "endian test failed" -unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E'; -EOF -od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian +test_cpp_condition stdlib.h "defined(__BYTE_ORDER__) && (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__)" && enable bigendian check_cc const_nan math.h "struct { double d; } static const bar[] = { { NAN } }" -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-04-09 13:50 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-09 13:50 J. Dekker [this message] 2024-04-09 13:50 ` [FFmpeg-devel] [PATCH v3 2/5] ffbuild/libversion.sh: add shebang J. Dekker 2024-04-09 21:52 ` Marth64 2024-04-09 22:27 ` Henrik Gramner via ffmpeg-devel 2024-04-09 22:52 ` Marth64 2024-04-09 23:00 ` Marth64 2024-04-09 13:50 ` [FFmpeg-devel] [PATCH v3 3/5] configure: switch to shebang without space J. Dekker 2024-04-09 13:55 ` Martin Storsjö 2024-04-09 14:03 ` J. Dekker 2024-04-09 13:50 ` [FFmpeg-devel] [PATCH v3 4/5] tests/fate.sh: " J. Dekker 2024-04-09 13:50 ` [FFmpeg-devel] [PATCH v3 5/5] doc/texidep: " J. Dekker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240409135034.95513-1-jdek@itanimul.li \ --to=jdek@itanimul.li \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git