From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC76F4934A for ; Mon, 8 Apr 2024 20:18:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BE5468D45A; Mon, 8 Apr 2024 23:18:42 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7940068D391 for ; Mon, 8 Apr 2024 23:18:35 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CEB81240002 for ; Mon, 8 Apr 2024 20:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712607515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wmTpK6snX7Rpelpmxd6WUdOnWGP0ZdYJlEU5eu1Fv0c=; b=gB/ji6GmeXXIWr/wcHabxxsWHzbkjaipJ7Qw91K6piid/FMZKV7M4VM/vLoApqBLpiFFVQ 4ffUsnX243fWJCbqXH8TMnnXmd8DdHFcWxw/X7kx0rZTA8tBgq6ZHYPnVKDU3b+89d74ub RQjaaHZ8ZS1348vEf5nTgk7rrxtxvJRAw733K09nwtA22Xn+Vo+QCsfeK/IzSMzZZDu3ta HiAEGc+6XOvK0/jPNFK8EGgvX4DN6qH0007TsAbWOWRjWN4+4HAOFFiVuTRWOPpcwzqh/m Fm+ALrciLr4KG+SIHEr1JhL/IjMQ9sGEpr8KkXCExbRiuDY0B1I2xkgrShjDkw== Date: Mon, 8 Apr 2024 22:18:33 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240408201833.GI6420@pb2> References: <20240405185721.111072-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20240405185721.111072-1-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3558878918437193616==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3558878918437193616== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P2l165wJKzsdFXew" Content-Disposition: inline --P2l165wJKzsdFXew Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 05, 2024 at 08:57:11PM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > This replaces the myriad of existing lists in AVCodec by a unified API > call, allowing us to (ultimately) trim down the sizeof(AVCodec) quite > substantially, while also making this more trivially extensible. >=20 > In addition to the already covered lists, add two new entries for color > space and color range, mirroring the newly added negotiable fields in > libavfilter. >=20 > I decided to drop the explicit length field from the API proposed by > Andreas Rheinhardt, because having it in place ended up complicating > both the codec side and the client side implementations, while also > being strictly less flexible (it's trivial to recover a length given > a terminator, but requires allocation to add a terminator given > a length). Using a terminator also presents less of a porting challenge > for existing users of the current API. >=20 > Once the deprecation period passes for the existing public fields, the > rough plan is to move the commonly used fields (such as > pix_fmt/sample_fmt) into FFCodec, possibly as a union of audio and video > configuration types, and then implement the rarely used fields with > custom callbacks. > --- > doc/APIchanges | 5 ++++ > libavcodec/avcodec.c | 51 +++++++++++++++++++++++++++++++++++++ > libavcodec/avcodec.h | 27 ++++++++++++++++++++ > libavcodec/codec.h | 19 +++++++++++--- > libavcodec/codec_internal.h | 21 +++++++++++++++ > libavcodec/version.h | 4 +-- > 6 files changed, 121 insertions(+), 6 deletions(-) This patchset seems to overlap a bit with AVOptionRanges I think ideally the user should at some point be able to query using some API on a AVCodecContext/AVCodecParameters/AVFormatContex/AVStream what for that specific instance are supported settings for each field The API here seems to use a enum, which can make sense but it differs from how AVOption works which doesnt use enums to identify fields [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --P2l165wJKzsdFXew Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZhRREAAKCRBhHseHBAsP q44WAJ9DkHMmOPx5e/LNw0rgcdO8yG7yVACfeg0TKucRsUgfu3HxGCObxFYSQ74= =vf9+ -----END PGP SIGNATURE----- --P2l165wJKzsdFXew-- --===============3558878918437193616== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3558878918437193616==--