From: Frank Plowman <post@frankplowman.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Frank Plowman <post@frankplowman.com>
Subject: [FFmpeg-devel] [PATCH] lavc/vvc: Fix left shifts of negative values
Date: Mon, 08 Apr 2024 16:07:02 +0000 (UTC)
Message-ID: <20240408160658.428236-1-post@frankplowman.com> (raw)
All these variables lie in the range [-12..12]
Signed-off-by: Frank Plowman <post@frankplowman.com>
---
libavcodec/vvc/ps.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c
index 3c71c34bae..1b23675c98 100644
--- a/libavcodec/vvc/ps.c
+++ b/libavcodec/vvc/ps.c
@@ -1196,12 +1196,12 @@ static void sh_deblock_offsets(VVCSH *sh)
const H266RawSliceHeader *r = sh->r;
if (!r->sh_deblocking_filter_disabled_flag) {
- sh->deblock.beta_offset[LUMA] = r->sh_luma_beta_offset_div2 << 1;
- sh->deblock.tc_offset[LUMA] = r->sh_luma_tc_offset_div2 << 1;
- sh->deblock.beta_offset[CB] = r->sh_cb_beta_offset_div2 << 1;
- sh->deblock.tc_offset[CB] = r->sh_cb_tc_offset_div2 << 1;
- sh->deblock.beta_offset[CR] = r->sh_cr_beta_offset_div2 << 1;
- sh->deblock.tc_offset[CR] = r->sh_cr_tc_offset_div2 << 1;
+ sh->deblock.beta_offset[LUMA] = r->sh_luma_beta_offset_div2 * 2;
+ sh->deblock.tc_offset[LUMA] = r->sh_luma_tc_offset_div2 * 2;
+ sh->deblock.beta_offset[CB] = r->sh_cb_beta_offset_div2 * 2;
+ sh->deblock.tc_offset[CB] = r->sh_cb_tc_offset_div2 * 2;
+ sh->deblock.beta_offset[CR] = r->sh_cr_beta_offset_div2 * 2;
+ sh->deblock.tc_offset[CR] = r->sh_cr_tc_offset_div2 * 2;
}
}
--
2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2024-04-08 16:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408160658.428236-1-post@frankplowman.com \
--to=post@frankplowman.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git