From: "J. Dekker" <jdek@itanimul.li> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v2 2/2] configure: simplify bigendian check Date: Mon, 8 Apr 2024 15:16:00 +0200 Message-ID: <20240408131600.81682-2-jdek@itanimul.li> (raw) In-Reply-To: <20240408131600.81682-1-jdek@itanimul.li> The preferred way to use LTO is --enable-lto but often times packagers still end up with -flto in cflags for various reasons. Using grep on binary object files is brittle and relies on specific object representation, which in the case of LLVM bitcode, debug-info or other intermediary formats can fail silently. This patch changes the check to a more commonly used define for big-endian systems. More checks may need to be added in the future to cover legacy machines. Signed-off-by: J. Dekker <jdek@itanimul.li> --- configure | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b/configure index 7b6f48e631..e787f13e0b 100755 --- a/configure +++ b/configure @@ -6120,11 +6120,7 @@ extern_prefix=${sym%%ff_extern*} check_cc pragma_deprecated "" '_Pragma("GCC diagnostic push") _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")' -# The global variable ensures the bits appear unchanged in the object file. -test_cc <<EOF || die "endian test failed" -unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E'; -EOF -od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian +test_cpp_condition stdlib.h "defined(__BYTE_ORDER__) && (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__)" && enable bigendian check_cc const_nan math.h "struct { double d; } static const bar[] = { { NAN } }" -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-08 13:16 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-08 13:15 [FFmpeg-devel] [PATCH v2 1/2] configure,etc: unify shebang usage J. Dekker 2024-04-08 13:16 ` J. Dekker [this message] 2024-04-09 9:03 ` [FFmpeg-devel] [PATCH v2 2/2] configure: simplify bigendian check Martin Storsjö 2024-04-09 8:58 ` [FFmpeg-devel] [PATCH v2 1/2] configure, etc: unify shebang usage Martin Storsjö
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240408131600.81682-2-jdek@itanimul.li \ --to=jdek@itanimul.li \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git