Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 04/11] avcodec/libx265: switch to get_supported_config()
Date: Fri,  5 Apr 2024 20:57:14 +0200
Message-ID: <20240405185721.111072-4-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20240405185721.111072-1-ffmpeg@haasn.xyz>

From: Niklas Haas <git@haasn.dev>

---
 libavcodec/libx265.c | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c
index 0645cd20457..ff1e8463aa1 100644
--- a/libavcodec/libx265.c
+++ b/libavcodec/libx265.c
@@ -892,14 +892,24 @@ static const enum AVPixelFormat x265_csp_twelve[] = {
     AV_PIX_FMT_NONE
 };
 
-static av_cold void libx265_encode_init_csp(FFCodec *codec)
+static int libx265_get_supported_config(const AVCodecContext *avctx,
+                                        const AVCodec *codec,
+                                        enum AVCodecConfig config,
+                                        unsigned flags, const void **out)
 {
-    if (x265_api_get(12))
-        codec->p.pix_fmts = x265_csp_twelve;
-    else if (x265_api_get(10))
-        codec->p.pix_fmts = x265_csp_ten;
-    else if (x265_api_get(8))
-        codec->p.pix_fmts = x265_csp_eight;
+    if (config == AV_CODEC_CONFIG_PIX_FORMAT) {
+        if (x265_api_get(12))
+            *out = x265_csp_twelve;
+        else if (x265_api_get(10))
+            *out = x265_csp_ten;
+        else if (x265_api_get(8))
+            *out = x265_csp_eight;
+        else
+            return AVERROR_EXTERNAL;
+        return 0;
+    }
+
+    return ff_default_get_supported_config(avctx, codec, config, flags, out);
 }
 
 #define OFFSET(x) offsetof(libx265Context, x)
@@ -951,7 +961,7 @@ FFCodec ff_libx265_encoder = {
     .p.priv_class     = &class,
     .p.wrapper_name   = "libx265",
     .init             = libx265_encode_init,
-    .init_static_data = libx265_encode_init_csp,
+    .get_supported_config = libx265_get_supported_config,
     FF_CODEC_ENCODE_CB(libx265_encode_frame),
     .close            = libx265_encode_close,
     .priv_data_size   = sizeof(libx265Context),
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-04-05 18:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 18:57 [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 02/11] avcodec/encode: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 03/11] avcodec/allcodecs: add backcompat for new config API Niklas Haas
2024-04-05 18:57 ` Niklas Haas [this message]
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 05/11] avcodec/libvpxenc: switch to get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 06/11] avcodec/libaomenc: " Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 07/11] avcodec/codec_internal: nuke init_static_data() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 08/11] fftools/opt_common: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 19:36   ` James Almer
2024-04-06 11:38     ` Niklas Haas
2024-04-07  0:10       ` James Almer
2024-04-08 11:15         ` Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 09/11] fftools: drop unused/hacky macros Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 10/11] fftools/ffmpeg_mux_init: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 11/11] fftools/ffmpeg_filter: " Niklas Haas
2024-04-05 19:01 ` [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config() Niklas Haas
2024-04-06 23:16 ` Michael Niedermayer
2024-04-07 11:47   ` Anton Khirnov
2024-04-08 11:15   ` Niklas Haas
2024-04-08 20:18 ` Michael Niedermayer
2024-04-08 20:23   ` Michael Niedermayer
2024-04-08 21:55   ` Niklas Haas
2024-04-10 22:09     ` Michael Niedermayer
2024-05-02 10:16       ` Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405185721.111072-4-ffmpeg@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=git@haasn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git