From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 10/11] fftools/ffmpeg_mux_init: switch to avcodec_get_supported_config()
Date: Fri, 5 Apr 2024 20:57:20 +0200
Message-ID: <20240405185721.111072-10-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20240405185721.111072-1-ffmpeg@haasn.xyz>
From: Niklas Haas <git@haasn.dev>
---
fftools/ffmpeg_mux_init.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index d3d7d022ff6..508c4f7a697 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -511,13 +511,19 @@ static int fmt_in_list(const int *formats, int format)
}
static enum AVPixelFormat
-choose_pixel_fmt(const AVCodec *codec, enum AVPixelFormat target)
+choose_pixel_fmt(const AVCodecContext *avctx, enum AVPixelFormat target)
{
- const enum AVPixelFormat *p = codec->pix_fmts;
+ const enum AVPixelFormat *p;
const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(target);
//FIXME: This should check for AV_PIX_FMT_FLAG_ALPHA after PAL8 pixel format without alpha is implemented
int has_alpha = desc ? desc->nb_components % 2 == 0 : 0;
enum AVPixelFormat best= AV_PIX_FMT_NONE;
+ int ret;
+
+ ret = avcodec_get_supported_config(avctx, NULL, AV_CODEC_CONFIG_PIX_FORMAT,
+ 0, (const void **) &p);
+ if (ret < 0)
+ return AV_PIX_FMT_NONE;
for (; *p != AV_PIX_FMT_NONE; p++) {
best = av_find_best_pix_fmt_of_2(best, *p, target, has_alpha, NULL);
@@ -529,7 +535,7 @@ choose_pixel_fmt(const AVCodec *codec, enum AVPixelFormat target)
av_log(NULL, AV_LOG_WARNING,
"Incompatible pixel format '%s' for codec '%s', auto-selecting format '%s'\n",
av_get_pix_fmt_name(target),
- codec->name,
+ avctx->codec->name,
av_get_pix_fmt_name(best));
return best;
}
@@ -538,8 +544,9 @@ choose_pixel_fmt(const AVCodec *codec, enum AVPixelFormat target)
static enum AVPixelFormat pix_fmt_parse(OutputStream *ost, const char *name)
{
- const enum AVPixelFormat *fmts = ost->enc_ctx->codec->pix_fmts;
+ const enum AVPixelFormat *fmts;// = ost->enc_ctx->codec->pix_fmts;
enum AVPixelFormat fmt;
+ int ret;
fmt = av_get_pix_fmt(name);
if (fmt == AV_PIX_FMT_NONE) {
@@ -547,6 +554,11 @@ static enum AVPixelFormat pix_fmt_parse(OutputStream *ost, const char *name)
return AV_PIX_FMT_NONE;
}
+ ret = avcodec_get_supported_config(ost->enc_ctx, NULL, AV_CODEC_CONFIG_PIX_FORMAT,
+ 0, (const void **) fmts);
+ if (ret < 0)
+ return AV_PIX_FMT_NONE;
+
/* when the user specified-format is an alias for an endianness-specific
* one (e.g. rgb48 -> rgb48be/le), it gets translated into the native
* endianness by av_get_pix_fmt();
@@ -574,7 +586,7 @@ static enum AVPixelFormat pix_fmt_parse(OutputStream *ost, const char *name)
}
if (fmts && !fmt_in_list(fmts, fmt))
- fmt = choose_pixel_fmt(ost->enc_ctx->codec, fmt);
+ fmt = choose_pixel_fmt(ost->enc_ctx, fmt);
return fmt;
}
--
2.44.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-05 18:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 18:57 [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 02/11] avcodec/encode: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 03/11] avcodec/allcodecs: add backcompat for new config API Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 04/11] avcodec/libx265: switch to get_supported_config() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 05/11] avcodec/libvpxenc: " Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 06/11] avcodec/libaomenc: " Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 07/11] avcodec/codec_internal: nuke init_static_data() Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 08/11] fftools/opt_common: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 19:36 ` James Almer
2024-04-06 11:38 ` Niklas Haas
2024-04-07 0:10 ` James Almer
2024-04-08 11:15 ` Niklas Haas
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 09/11] fftools: drop unused/hacky macros Niklas Haas
2024-04-05 18:57 ` Niklas Haas [this message]
2024-04-05 18:57 ` [FFmpeg-devel] [PATCH 11/11] fftools/ffmpeg_filter: switch to avcodec_get_supported_config() Niklas Haas
2024-04-05 19:01 ` [FFmpeg-devel] [PATCH 01/11] avcodec: add avcodec_get_supported_config() Niklas Haas
2024-04-06 23:16 ` Michael Niedermayer
2024-04-07 11:47 ` Anton Khirnov
2024-04-08 11:15 ` Niklas Haas
2024-04-08 20:18 ` Michael Niedermayer
2024-04-08 20:23 ` Michael Niedermayer
2024-04-08 21:55 ` Niklas Haas
2024-04-10 22:09 ` Michael Niedermayer
2024-05-02 10:16 ` Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405185721.111072-10-ffmpeg@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git