From: Antoine Soulier via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Antoine Soulier <asoulier@google.com> Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3dec: Retrieve duration of the last packet from the demux Date: Thu, 4 Apr 2024 22:57:33 +0000 Message-ID: <20240404225734.3036715-1-asoulier@google.com> (raw) From: Antoine SOULIER <asoulier@google.com> Use the packet duration field to invalid last samples of the last frame. --- libavcodec/liblc3dec.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/liblc3dec.c b/libavcodec/liblc3dec.c index 90da28679b..d250ace38a 100644 --- a/libavcodec/liblc3dec.c +++ b/libavcodec/liblc3dec.c @@ -34,7 +34,6 @@ typedef struct LibLC3DecContext { int frame_us, srate_hz, hr_mode; void *decoder_mem; lc3_decoder_t decoder[DECODER_MAX_CHANNELS]; - int64_t length; } LibLC3DecContext; static av_cold int liblc3_decode_init(AVCodecContext *avctx) @@ -44,12 +43,12 @@ static av_cold int liblc3_decode_init(AVCodecContext *avctx) int ep_mode; unsigned decoder_size; - if (avctx->extradata_size < 10) + if (avctx->extradata_size < 6) return AVERROR_INVALIDDATA; if (channels < 0 || channels > DECODER_MAX_CHANNELS) { av_log(avctx, AV_LOG_ERROR, "Invalid number of channels %d. Max %d channels are accepted\n", - channels, DECODER_MAX_CHANNES); + channels, DECODER_MAX_CHANNELS); return AVERROR(EINVAL); } @@ -57,7 +56,6 @@ static av_cold int liblc3_decode_init(AVCodecContext *avctx) liblc3->srate_hz = avctx->sample_rate; ep_mode = AV_RL16(avctx->extradata + 2); liblc3->hr_mode = AV_RL16(avctx->extradata + 4); - liblc3->length = AV_RL32(avctx->extradata + 6); if (ep_mode != 0) { av_log(avctx, AV_LOG_ERROR, "Error protection mode is not supported.\n"); @@ -126,11 +124,7 @@ static int liblc3_decode(AVCodecContext *avctx, AVFrame *frame, in += nbytes; } - if (liblc3->length > 0) { - int64_t end_pts = liblc3->length + avctx->delay; - frame->nb_samples = FFMIN(frame->nb_samples, - FFMAX(end_pts - frame->pts, 0)); - } + frame->nb_samples = FFMIN(frame->nb_samples, avpkt->duration); *got_frame_ptr = 1; -- 2.44.0.478.gd926399ef9-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-04-04 22:57 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-04 22:57 Antoine Soulier via ffmpeg-devel [this message] 2024-04-04 22:57 ` [FFmpeg-devel] [PATCH 2/2] avformat/lc3: Add file format for LC3/LC3plus transport Antoine Soulier via ffmpeg-devel 2024-04-06 7:54 ` Stefano Sabatini 2024-04-06 7:41 ` [FFmpeg-devel] [PATCH 1/2] avcodec/liblc3dec: Retrieve duration of the last packet from the demux Stefano Sabatini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240404225734.3036715-1-asoulier@google.com \ --to=ffmpeg-devel@ffmpeg.org \ --cc=asoulier@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git