From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 174794A656 for ; Tue, 2 Apr 2024 21:23:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A576C68CF9D; Wed, 3 Apr 2024 00:23:28 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BFEA968C5B9 for ; Wed, 3 Apr 2024 00:23:22 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E544BFF802 for ; Tue, 2 Apr 2024 21:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712093002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pIPcPP6oZz6sl3jnP6g6GbLI1vAy9eK1aP1xAfOuhJU=; b=ELySJXH4N1n7iiqhNhl/StLo2dbtVB22g6RT/929rKLJHjHRQPzZTYugWvXrNrlYfKSOGi J0wY24FZ+ZPV1gEcDpf+5dCq7OEghJ/gKLvwh0WZrqG5UplY4ivH3MYsNaTJZa1nZrM/lm Jr8Wa6y1VKYE76sCOnfYJngb0wPsc22B9+LWlIgkAKXEsOKCeymqAE+GgKV6mTVo2wsw1/ ABtND/pptvT+4O+BAUB2GZtTtuMey7pnDH6ZddkuyjdSqtJlLzuvP/xg/Dj5RGe+SmUvov WA6lA548rr+N84B2ZrCE8iTJkVz/udm6XMDFHnMjuStf8X2JhNHjwbGTf8Fvjg== Date: Tue, 2 Apr 2024 23:23:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240402212321.GP6420@pb2> References: <20240401205607.9093-1-michael@niedermayer.cc> <20240401205607.9093-5-michael@niedermayer.cc> <44df12c6-8d0b-4615-85be-d6447eee684d@gmail.com> MIME-Version: 1.0 In-Reply-To: <44df12c6-8d0b-4615-85be-d6447eee684d@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hevc_ps: --typo X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6488846579631144934==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6488846579631144934== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d0DgU1ApAChvs5Cg" Content-Disposition: inline --d0DgU1ApAChvs5Cg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 02, 2024 at 09:12:09AM -0300, James Almer wrote: > On 4/1/2024 5:56 PM, Michael Niedermayer wrote: > > Fixes: null pointer dereference > > Fixes: 67737/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuz= zer-4858162608930816 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/hevc_ps.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > > index 38b3721a6d5..25f087ed754 100644 > > --- a/libavcodec/hevc_ps.c > > +++ b/libavcodec/hevc_ps.c > > @@ -460,7 +460,7 @@ int ff_hevc_decode_nal_vps(GetBitContext *gb, AVCod= ecContext *avctx, > > int ret =3D AVERROR_INVALIDDATA; > > HEVCVPS *vps; > > - if (ps->pps_list[vps_id]) { > > + if (ps->vps_list[vps_id]) { > > const HEVCVPS *vps1 =3D ps->vps_list[vps_id]; > > if (vps1->data_size =3D=3D nal_size && > > !memcmp(vps1->data, gb->buffer, vps1->data_size)) >=20 > LGTM. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better. --d0DgU1ApAChvs5Cg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgx3QgAKCRBhHseHBAsP q91RAKCLS02Iauit9Rf/fUtOuj6Kp3+cGgCeIRx3jiT4YVR1ktLm+ooQCigl6wc= =cEBL -----END PGP SIGNATURE----- --d0DgU1ApAChvs5Cg-- --===============6488846579631144934== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6488846579631144934==--