From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 72CB749AF0 for ; Tue, 2 Apr 2024 03:18:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB91F68D0C5; Tue, 2 Apr 2024 06:18:10 +0300 (EEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 444DE68D0A6 for ; Tue, 2 Apr 2024 06:18:05 +0300 (EEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e0edd0340fso42001305ad.2 for ; Mon, 01 Apr 2024 20:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712027883; x=1712632683; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QOtJAnhNuq1t+a0g+EZpL3rBqoyqNx8iYzruPICtfLE=; b=ByCUXQXM+hi9LVzwvkAC1HiRT8p0/6kWWHw9fW5F15RuHWd/VzpfNv/Q5S2vOG58wp nQ9dN4E98A9DP2iRzUugzvbgjpC0oYmDU26pR66bJtU4wr2zlDqwcIfQrAa6r+hqc7Do VmZYlXVgrAc0O+UaCTRtoLfgG7Q4o/a0P1FSuYkQfKXgl92i/NMCnIz2NmC3vL7LhQBE bbXPKxZAmyiL6tzP8fQchtJHBWk3JQgdoEEriKNK/cDkDUQgEpOW++3c+9TYfFhfUoUj +RVwkY1dkTw/4NGwKFO/vWbVgNEJqc9+VN2w9Acvmu0NTHLcGrvsOT6D+AN5ya77EZYM 3JLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712027883; x=1712632683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QOtJAnhNuq1t+a0g+EZpL3rBqoyqNx8iYzruPICtfLE=; b=Usuo0Cw9NBtELsqjogSa6Z+wTq/REvevoW5bHl6/f/ni7kfJ8AP74hE0RdxJ1B1kX7 pUcasXYdaunrajsU4WYM6xIbbvifkmXDWfDbVH56S1lcQV8RbtSOZ1qSd2oxggjpc4Nu 912RLu3iHDeGeoK2iUfhJ8OSyGuUOzfyg8meZWNJpq2VKF9PN/yLVx0aYSLQuC+AcOaE 2abYDS0rvsC9heTMXN0DvpTGkjg3QX8ceyCwagDH25sd6Eh/9gyAphRp+VbIXudlYz0W hIAS2YWTRpku+KbS1vWE+pylujyBUGiUg02GfhfaLPO1sWG7ztNuQfv74CV03RKZGXDx eHnQ== X-Gm-Message-State: AOJu0YylBIoUhnM87PkQO3XEzSipQqTpj+SR0uvoCmMHlD4ja9I3w9IE iq6R1a4Nky5rJMh8VHR1W5nO7GJhdcUQbKfMSsClU4SBhMgElV+fWWwKLiJN X-Google-Smtp-Source: AGHT+IHSdwsnxQwpMD4rEWLk0y5k4gZSsT/k79WJBcump3SzlMBQvbGhWg9STAlhlVIeu23gN3P25g== X-Received: by 2002:a17:902:ce84:b0:1e0:e85b:3389 with SMTP id f4-20020a170902ce8400b001e0e85b3389mr14809820plg.3.1712027882772; Mon, 01 Apr 2024 20:18:02 -0700 (PDT) Received: from localhost.localdomain ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id g12-20020a170902fe0c00b001e26ba8882fsm408652plj.287.2024.04.01.20.18.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 20:18:02 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 2 Apr 2024 00:17:59 -0300 Message-ID: <20240402031800.7159-2-jamrial@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402031800.7159-1-jamrial@gmail.com> References: <20240402031800.7159-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/3] avformat/mov: don't read key_size bytes twice in the keys atom X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: We only support mdta as type, yet we were not skipping other types, but rather reading key_size worth of bytes twice per entry. Signed-off-by: James Almer --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3273e2e89b..a935ef7326 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5049,6 +5049,7 @@ static int mov_read_keys(MOVContext *c, AVIOContext *pb, MOVAtom atom) key_size -= 8; if (type != MKTAG('m','d','t','a')) { avio_skip(pb, key_size); + continue; } c->meta_keys[i] = av_mallocz(key_size + 1); if (!c->meta_keys[i]) -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".