From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 094D649075 for ; Mon, 1 Apr 2024 23:40:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E75668CF98; Tue, 2 Apr 2024 02:40:15 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C60C68CDB0 for ; Tue, 2 Apr 2024 02:40:09 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 84CF640002 for ; Mon, 1 Apr 2024 23:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1712014808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=98L2w5P9zLo0IY5U8bWRghUyhd8Lb3yxPHiLJOzrsLk=; b=W1aMkJ9jwVt51vsR87s5DJAvPD+MYMDm85E/G9v4DSLezTIsQPqD0yHhIh2t7zv23QSbho MwLCoOi4qpbFMTo8CApFCXaUND5Mviymv87+s5Ox6Lrawn1AGl59KB2tyuJXrNT/7XTcO5 D6sp8yaBmwaKomGK3u+4g7Mt5pSwdv3ZpXjOag+ujQts9XBTdFEk4eNeEjxE1ip/JGyYFT Xy5CFgYb6fM+8CdRZwGKxKYtEEcpRBmN2NShGLdRQB4wj7o9J7LGHgZothCIPzYPqvUoeA rlSHTYVytU/gDoV96iLXjt3OLqHk/hqMv95CehoDqaNLhMKZL6/HzonAXycZcg== Date: Tue, 2 Apr 2024 01:40:07 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240401234007.GM6420@pb2> References: <20240401205607.9093-1-michael@niedermayer.cc> <77140ca3-bf2f-42db-9a76-264529c9ee5a@gmail.com> MIME-Version: 1.0 In-Reply-To: <77140ca3-bf2f-42db-9a76-264529c9ee5a@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/6] avformat/isom: Uninit layout in ff_mp4_read_dec_config_descr() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2323246352879912413==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2323246352879912413== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uzL93NWIAXjAeCwr" Content-Disposition: inline --uzL93NWIAXjAeCwr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 01, 2024 at 06:33:22PM -0300, James Almer wrote: > On 4/1/2024 5:56 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: 67442/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-50688= 13261406208 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/isom.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/libavformat/isom.c b/libavformat/isom.c > > index 9fbccd4437f..c5930bd4d87 100644 > > --- a/libavformat/isom.c > > +++ b/libavformat/isom.c > > @@ -359,6 +359,7 @@ int ff_mp4_read_dec_config_descr(AVFormatContext *f= c, AVStream *st, AVIOContext > > st->codecpar->extrada= ta_size, 1, fc); > > if (ret < 0) > > return ret; > > + av_channel_layout_uninit(&st->codecpar->ch_layout); > > st->codecpar->ch_layout.order =3D AV_CHANNEL_ORDER_UNSPEC; >=20 > Not strictly related to this fix, but should we really drop the layout he= re > by forcing unspec? We're also not even bothering to check if cfg.channels > matches st->codecpar->ch_layout.nb_channels. I was wondering the same. I was hoping someone would know the specs well enouh to just say straight "this and that isnt legal together error out if thats true" thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates --uzL93NWIAXjAeCwr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgtF1AAKCRBhHseHBAsP q/e2AJ9812rO7xZ7bQF+A1YQL8JR9u9b7QCggVLNs7huwHQr8KxADOeNcaCTCe8= =VtZ6 -----END PGP SIGNATURE----- --uzL93NWIAXjAeCwr-- --===============2323246352879912413== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2323246352879912413==--