From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C61FB48FFC for ; Mon, 1 Apr 2024 16:26:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D038A68CA93; Mon, 1 Apr 2024 19:26:55 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4172A68C1C4 for ; Mon, 1 Apr 2024 19:26:49 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7154CE0003 for ; Mon, 1 Apr 2024 16:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711988808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HSAhq7G5SGizpw9gjnwThKv9mzh5HH4BMXSXOraKxf0=; b=GjSYYqeqNwS3fdmlVW2vYvGsLPuvLUxMXgpUEJkPX8W8bBy7xrvhiHZoLM9J60Byhh6QaW ZFPIcFx8r+GPrZWsdosyfJf/EpasG0sZNd7Xnud47Xv1z5VuHpLWzMy/DzrNoGiImJQhxw usMxUsXk2ILDBDnqHHiBsQGCUXs0BoY0JKFG+qGBSvKhQtipXR5CN/fJfNHk8Ww77xdxm6 M7vtqlONeFX6wnADgFXs7p/dMAlmEnRiTWM60+KZMf/fRjrGD5WUzk9lcBbyHcW8V9OVJH EalVhUqGjK0dft5ZdEwl4we0lRV0HjgvFO0r16sVy8CE9GLRN0ig6eZFQUAyZg== Date: Mon, 1 Apr 2024 18:26:47 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240401162647.GF6420@pb2> References: <20240401160835.19523-1-michael@niedermayer.cc> <3faabf91-87d3-66ec-8210-c5d893acda05@passwd.hu> MIME-Version: 1.0 In-Reply-To: <3faabf91-87d3-66ec-8210-c5d893acda05@passwd.hu> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check that edit_unit_byte_count is not negative X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7729875990369978948==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7729875990369978948== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HFHWHG6+6mu6J15i" Content-Disposition: inline --HFHWHG6+6mu6J15i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 01, 2024 at 06:22:47PM +0200, Marton Balint wrote: >=20 >=20 > On Mon, 1 Apr 2024, Michael Niedermayer wrote: >=20 > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index e484db052ef..37446963369 100644 > > --- a/libavformat/mxfdec.c > > +++ b/libavformat/mxfdec.c > > @@ -1245,9 +1245,13 @@ static int mxf_read_index_entry_array(AVIOContex= t *pb, MXFIndexTableSegment *seg > > static int mxf_read_index_table_segment(void *arg, AVIOContext *pb, int= tag, int size, UID uid, int64_t klv_offset) > > { > > MXFIndexTableSegment *segment =3D arg; > > + int tmp; > > switch(tag) { > > case 0x3F05: > > - segment->edit_unit_byte_count =3D avio_rb32(pb); >=20 > Why not simply make segment->edit_unit_byte_count unsigned? ok will apply that instead thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --HFHWHG6+6mu6J15i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgrgRwAKCRBhHseHBAsP q+XrAJ9hdXJnWAd542Rzf/O9uEi996ugCwCeKLMtjN4XImFOPuzNK7FdO+ol6+0= =sleR -----END PGP SIGNATURE----- --HFHWHG6+6mu6J15i-- --===============7729875990369978948== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7729875990369978948==--