From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C5E8F48F4F for ; Sun, 31 Mar 2024 15:08:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85F1368CAF0; Sun, 31 Mar 2024 18:07:59 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 03EE068C5DA for ; Sun, 31 Mar 2024 18:07:53 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4FF7EE0002 for ; Sun, 31 Mar 2024 15:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711897673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QKPAnPTyAzX6DuXjrqIFVMu6PdR+Mf1fb1HC9eaoyJU=; b=fICRmBOXSbpT0RS4XEf8CTdcRdvpTnuSjtfgvZMbu5g7b0i2/JzxIa/qBBWDcc2ndH422p a/s7OMOwUIZOezU8hqrjIWP9LLETI/4DGfabMTAiYQYD55xm5xEP4AVy4GmWsesPCct5tJ AqJ8Jg8KzNfbp2JLTI34+fzAe3pAcfM8jQ6eJtPD+sxKWxNCBKcCRC9NjH0rUSwqb2A5xu xBjNxZnIdsbCRUVW/slqb4YmXcbp2hdyPPT4u4BEuORgAJentC8UvonD1EbXgzMzfu5uAG eA+jsMaB/7bopm1EZxAgjdFacG3cXOAiHljnEhTctkJh2ivdD1ovesiv2abkHg== Date: Sun, 31 Mar 2024 17:07:52 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240331150752.GY6420@pb2> References: <20240328201132.1804716-1-marth64@proxyid.net> <20240328201132.1804716-3-marth64@proxyid.net> <20240330002353.GU6420@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5222556692352047844==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5222556692352047844== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c8gGj3MN7jz/+Phq" Content-Disposition: inline --c8gGj3MN7jz/+Phq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 30, 2024 at 03:55:13PM +0100, Stefano Sabatini wrote: > On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote: > > On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote: > > [...] > >=20 > > > +static int rcwt_probe(const AVProbeData *p) > > > +{ > > > + return p->buf_size > RCWT_HEADER_SIZE && > > > + AV_RB16(p->buf) =3D=3D 0xCCCC && > > > + AV_RB8(p->buf + 2) =3D=3D 0xED && > > > + AV_RB16(p->buf + 6) =3D=3D 0x0001 ? 50 : 0; > > > +} > > > + > > > +const FFInputFormat ff_rcwt_demuxer =3D { > > > + .p.name =3D "rcwt", > > > + .p.long_name =3D NULL_IF_CONFIG_SMALL("RCWT (Raw Captions Wit= h Time)"), > > > + .p.extensions =3D "bin", > >=20 >=20 > > this causes a mp3 i have to be misdetected > > ~/videos/sbQ9.bin > > (this is a actual file i had not a file crafted for this) > >=20 > > i think the entry for extensions should be removed (which fixes this) > > having a ".bin" is not a strong indication that its rcwt >=20 > Is this blocking or can it be addressed later? Also, if this needs to droping the "bin" from the demuxer should be trivial to do, the extension is IIRC used mainly for probing and its wrong for probing to associate bin = with any specific format. > be modified the muxer should be as well. maybe, yes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange --c8gGj3MN7jz/+Phq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgl8QgAKCRBhHseHBAsP qyItAJ9c8y9hls1Msxn4NAkSEx/E9x8K5gCfWLPJ8iuiyOqyAMRBU3N9guuOuQA= =4LKo -----END PGP SIGNATURE----- --c8gGj3MN7jz/+Phq-- --===============5222556692352047844== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5222556692352047844==--