* [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball @ 2024-03-30 14:02 Michael Niedermayer 2024-03-30 14:51 ` James Almer 0 siblings, 1 reply; 6+ messages in thread From: Michael Niedermayer @ 2024-03-30 14:02 UTC (permalink / raw) To: FFmpeg development discussions and patches Iam not 100% sure this is the best place to put this. But we should somewhere describe what differences are expected Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- src/download | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/download b/src/download index 0e6fa7e..34733de 100644 --- a/src/download +++ b/src/download @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293A5644F10B4322F04D67658D8 gpg: issuer "ffmpeg-devel@ffmpeg.org" gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel@ffmpeg.org>" [full]</pre> </li> + <li> + Verify that the release tarball matches the git tag: (expected differences are missing .git, .gitignore and .gitattributes and an additional VERSION file) + <pre> + $ diff -ru ffmpeg-5.1.4 gitdir2 +Only in gitdir2/doc/doxy: .gitignore +Only in gitdir2/doc/examples: .gitignore +Only in gitdir2/doc: .gitignore +Only in gitdir2/ffbuild: .gitignore +Only in gitdir2: .git +Only in gitdir2: .gitattributes +Only in gitdir2: .gitignore +Only in gitdir2/libavcodec: .gitignore +Only in gitdir2/libavcodec/tests: .gitignore +Only in gitdir2/libavdevice: .gitignore +Only in gitdir2/libavdevice/tests: .gitignore +Only in gitdir2/libavfilter: .gitignore +Only in gitdir2/libavfilter/opencl: .gitignore +Only in gitdir2/libavfilter/tests: .gitignore +Only in gitdir2/libavformat: .gitignore +Only in gitdir2/libavformat/tests: .gitignore +Only in gitdir2/libavutil: .gitignore +Only in gitdir2/libavutil/tests: .gitignore +Only in gitdir2/libswresample/tests: .gitignore +Only in gitdir2/libswscale/tests: .gitignore +Only in gitdir2/tests/api: .gitignore +Only in gitdir2/tests/checkasm: .gitignore +Only in gitdir2/tests: .gitignore +Only in gitdir2/tools: .gitignore +Only in ffmpeg-5.1.4: VERSION + </pre> + </li> + <li> + Verify that the tag in git is signed + </li> </ol> </p> -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball 2024-03-30 14:02 [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball Michael Niedermayer @ 2024-03-30 14:51 ` James Almer 2024-03-30 17:30 ` Michael Niedermayer 0 siblings, 1 reply; 6+ messages in thread From: James Almer @ 2024-03-30 14:51 UTC (permalink / raw) To: ffmpeg-devel On 3/30/2024 11:02 AM, Michael Niedermayer wrote: > Iam not 100% sure this is the best place to put this. But we should somewhere > describe what differences are expected > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > src/download | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/src/download b/src/download > index 0e6fa7e..34733de 100644 > --- a/src/download > +++ b/src/download > @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293A5644F10B4322F04D67658D8 > gpg: issuer "ffmpeg-devel@ffmpeg.org" > gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel@ffmpeg.org>" [full]</pre> > </li> > + <li> > + Verify that the release tarball matches the git tag: (expected differences are missing .git, .gitignore and .gitattributes and an additional VERSION file) > + <pre> > + $ diff -ru ffmpeg-5.1.4 gitdir2 > +Only in gitdir2/doc/doxy: .gitignore > +Only in gitdir2/doc/examples: .gitignore > +Only in gitdir2/doc: .gitignore > +Only in gitdir2/ffbuild: .gitignore > +Only in gitdir2: .git > +Only in gitdir2: .gitattributes > +Only in gitdir2: .gitignore > +Only in gitdir2/libavcodec: .gitignore > +Only in gitdir2/libavcodec/tests: .gitignore > +Only in gitdir2/libavdevice: .gitignore > +Only in gitdir2/libavdevice/tests: .gitignore > +Only in gitdir2/libavfilter: .gitignore > +Only in gitdir2/libavfilter/opencl: .gitignore > +Only in gitdir2/libavfilter/tests: .gitignore > +Only in gitdir2/libavformat: .gitignore > +Only in gitdir2/libavformat/tests: .gitignore > +Only in gitdir2/libavutil: .gitignore > +Only in gitdir2/libavutil/tests: .gitignore > +Only in gitdir2/libswresample/tests: .gitignore > +Only in gitdir2/libswscale/tests: .gitignore > +Only in gitdir2/tests/api: .gitignore > +Only in gitdir2/tests/checkasm: .gitignore > +Only in gitdir2/tests: .gitignore > +Only in gitdir2/tools: .gitignore > +Only in ffmpeg-5.1.4: VERSION > + </pre> > + </li> > + <li> > + Verify that the tag in git is signed The tags are signed with your key made for this purpose, DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one listed above. You should include it here the same way, unless the signature check for tags is documented elsewhere? If so, a link to that place. > + </li> > </ol> > </p> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball 2024-03-30 14:51 ` James Almer @ 2024-03-30 17:30 ` Michael Niedermayer 2024-03-30 17:31 ` James Almer 2024-03-30 20:30 ` Kieran Kunhya 0 siblings, 2 replies; 6+ messages in thread From: Michael Niedermayer @ 2024-03-30 17:30 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1.1: Type: text/plain, Size: 2833 bytes --] On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote: > On 3/30/2024 11:02 AM, Michael Niedermayer wrote: > > Iam not 100% sure this is the best place to put this. But we should somewhere > > describe what differences are expected > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > src/download | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/src/download b/src/download > > index 0e6fa7e..34733de 100644 > > --- a/src/download > > +++ b/src/download > > @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293A5644F10B4322F04D67658D8 > > gpg: issuer "ffmpeg-devel@ffmpeg.org" > > gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel@ffmpeg.org>" [full]</pre> > > </li> > > + <li> > > + Verify that the release tarball matches the git tag: (expected differences are missing .git, .gitignore and .gitattributes and an additional VERSION file) > > + <pre> > > + $ diff -ru ffmpeg-5.1.4 gitdir2 > > +Only in gitdir2/doc/doxy: .gitignore > > +Only in gitdir2/doc/examples: .gitignore > > +Only in gitdir2/doc: .gitignore > > +Only in gitdir2/ffbuild: .gitignore > > +Only in gitdir2: .git > > +Only in gitdir2: .gitattributes > > +Only in gitdir2: .gitignore > > +Only in gitdir2/libavcodec: .gitignore > > +Only in gitdir2/libavcodec/tests: .gitignore > > +Only in gitdir2/libavdevice: .gitignore > > +Only in gitdir2/libavdevice/tests: .gitignore > > +Only in gitdir2/libavfilter: .gitignore > > +Only in gitdir2/libavfilter/opencl: .gitignore > > +Only in gitdir2/libavfilter/tests: .gitignore > > +Only in gitdir2/libavformat: .gitignore > > +Only in gitdir2/libavformat/tests: .gitignore > > +Only in gitdir2/libavutil: .gitignore > > +Only in gitdir2/libavutil/tests: .gitignore > > +Only in gitdir2/libswresample/tests: .gitignore > > +Only in gitdir2/libswscale/tests: .gitignore > > +Only in gitdir2/tests/api: .gitignore > > +Only in gitdir2/tests/checkasm: .gitignore > > +Only in gitdir2/tests: .gitignore > > +Only in gitdir2/tools: .gitignore > > +Only in ffmpeg-5.1.4: VERSION > > + </pre> > > + </li> > > + <li> > > + Verify that the tag in git is signed > > The tags are signed with your key made for this purpose, > DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one > listed above. You should include it here the same way, unless the signature yes but before doing that, do you think this is the best place to put all this? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball 2024-03-30 17:30 ` Michael Niedermayer @ 2024-03-30 17:31 ` James Almer 2024-03-30 21:19 ` Michael Niedermayer 2024-03-30 20:30 ` Kieran Kunhya 1 sibling, 1 reply; 6+ messages in thread From: James Almer @ 2024-03-30 17:31 UTC (permalink / raw) To: ffmpeg-devel On 3/30/2024 2:30 PM, Michael Niedermayer wrote: > On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote: >> On 3/30/2024 11:02 AM, Michael Niedermayer wrote: >>> Iam not 100% sure this is the best place to put this. But we should somewhere >>> describe what differences are expected >>> >>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> >>> --- >>> src/download | 34 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >>> >>> diff --git a/src/download b/src/download >>> index 0e6fa7e..34733de 100644 >>> --- a/src/download >>> +++ b/src/download >>> @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293A5644F10B4322F04D67658D8 >>> gpg: issuer "ffmpeg-devel@ffmpeg.org" >>> gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel@ffmpeg.org>" [full]</pre> >>> </li> >>> + <li> >>> + Verify that the release tarball matches the git tag: (expected differences are missing .git, .gitignore and .gitattributes and an additional VERSION file) >>> + <pre> >>> + $ diff -ru ffmpeg-5.1.4 gitdir2 >>> +Only in gitdir2/doc/doxy: .gitignore >>> +Only in gitdir2/doc/examples: .gitignore >>> +Only in gitdir2/doc: .gitignore >>> +Only in gitdir2/ffbuild: .gitignore >>> +Only in gitdir2: .git >>> +Only in gitdir2: .gitattributes >>> +Only in gitdir2: .gitignore >>> +Only in gitdir2/libavcodec: .gitignore >>> +Only in gitdir2/libavcodec/tests: .gitignore >>> +Only in gitdir2/libavdevice: .gitignore >>> +Only in gitdir2/libavdevice/tests: .gitignore >>> +Only in gitdir2/libavfilter: .gitignore >>> +Only in gitdir2/libavfilter/opencl: .gitignore >>> +Only in gitdir2/libavfilter/tests: .gitignore >>> +Only in gitdir2/libavformat: .gitignore >>> +Only in gitdir2/libavformat/tests: .gitignore >>> +Only in gitdir2/libavutil: .gitignore >>> +Only in gitdir2/libavutil/tests: .gitignore >>> +Only in gitdir2/libswresample/tests: .gitignore >>> +Only in gitdir2/libswscale/tests: .gitignore >>> +Only in gitdir2/tests/api: .gitignore >>> +Only in gitdir2/tests/checkasm: .gitignore >>> +Only in gitdir2/tests: .gitignore >>> +Only in gitdir2/tools: .gitignore >>> +Only in ffmpeg-5.1.4: VERSION >>> + </pre> >>> + </li> >>> + <li> >>> + Verify that the tag in git is signed >> >> The tags are signed with your key made for this purpose, >> DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one >> listed above. You should include it here the same way, unless the signature > > yes but before doing that, do you think this is the best place to put all this? Sure, why would it not? It's the section where we explain how to verify releases. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball 2024-03-30 17:31 ` James Almer @ 2024-03-30 21:19 ` Michael Niedermayer 0 siblings, 0 replies; 6+ messages in thread From: Michael Niedermayer @ 2024-03-30 21:19 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1.1: Type: text/plain, Size: 3829 bytes --] On Sat, Mar 30, 2024 at 02:31:54PM -0300, James Almer wrote: > On 3/30/2024 2:30 PM, Michael Niedermayer wrote: > > On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote: > > > On 3/30/2024 11:02 AM, Michael Niedermayer wrote: > > > > Iam not 100% sure this is the best place to put this. But we should somewhere > > > > describe what differences are expected > > > > > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > > > --- > > > > src/download | 34 ++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 34 insertions(+) > > > > > > > > diff --git a/src/download b/src/download > > > > index 0e6fa7e..34733de 100644 > > > > --- a/src/download > > > > +++ b/src/download > > > > @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293A5644F10B4322F04D67658D8 > > > > gpg: issuer "ffmpeg-devel@ffmpeg.org" > > > > gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel@ffmpeg.org>" [full]</pre> > > > > </li> > > > > + <li> > > > > + Verify that the release tarball matches the git tag: (expected differences are missing .git, .gitignore and .gitattributes and an additional VERSION file) > > > > + <pre> > > > > + $ diff -ru ffmpeg-5.1.4 gitdir2 > > > > +Only in gitdir2/doc/doxy: .gitignore > > > > +Only in gitdir2/doc/examples: .gitignore > > > > +Only in gitdir2/doc: .gitignore > > > > +Only in gitdir2/ffbuild: .gitignore > > > > +Only in gitdir2: .git > > > > +Only in gitdir2: .gitattributes > > > > +Only in gitdir2: .gitignore > > > > +Only in gitdir2/libavcodec: .gitignore > > > > +Only in gitdir2/libavcodec/tests: .gitignore > > > > +Only in gitdir2/libavdevice: .gitignore > > > > +Only in gitdir2/libavdevice/tests: .gitignore > > > > +Only in gitdir2/libavfilter: .gitignore > > > > +Only in gitdir2/libavfilter/opencl: .gitignore > > > > +Only in gitdir2/libavfilter/tests: .gitignore > > > > +Only in gitdir2/libavformat: .gitignore > > > > +Only in gitdir2/libavformat/tests: .gitignore > > > > +Only in gitdir2/libavutil: .gitignore > > > > +Only in gitdir2/libavutil/tests: .gitignore > > > > +Only in gitdir2/libswresample/tests: .gitignore > > > > +Only in gitdir2/libswscale/tests: .gitignore > > > > +Only in gitdir2/tests/api: .gitignore > > > > +Only in gitdir2/tests/checkasm: .gitignore > > > > +Only in gitdir2/tests: .gitignore > > > > +Only in gitdir2/tools: .gitignore > > > > +Only in ffmpeg-5.1.4: VERSION > > > > + </pre> > > > > + </li> > > > > + <li> > > > > + Verify that the tag in git is signed > > > > > > The tags are signed with your key made for this purpose, > > > DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one > > > listed above. You should include it here the same way, unless the signature > > > > yes but before doing that, do you think this is the best place to put all this? > > Sure, why would it not? It's the section where we explain how to verify > releases. The verification ends with the tarball signature being verified. Checking the difference between 2 mirrors, or git vs. tarball is not verifying if the user obtained a unmodified copy of a release. It would check for a subset of variants of compromises on the FFmpeg side. I think we should publish somewhere how the difference between git and tarball should look. But iam not sure anything is achieved by asking everyone to download things twice and compare them. Maybe the security page is a better place ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball 2024-03-30 17:30 ` Michael Niedermayer 2024-03-30 17:31 ` James Almer @ 2024-03-30 20:30 ` Kieran Kunhya 1 sibling, 0 replies; 6+ messages in thread From: Kieran Kunhya @ 2024-03-30 20:30 UTC (permalink / raw) To: FFmpeg development discussions and patches On Sat, 30 Mar 2024 at 17:30, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote: > > On 3/30/2024 11:02 AM, Michael Niedermayer wrote: > > > Iam not 100% sure this is the best place to put this. But we should > somewhere > > > describe what differences are expected > > > > > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > > --- > > > src/download | 34 ++++++++++++++++++++++++++++++++++ > > > 1 file changed, 34 insertions(+) > > > > > > diff --git a/src/download b/src/download > > > index 0e6fa7e..34733de 100644 > > > --- a/src/download > > > +++ b/src/download > > > @@ -284,6 +284,40 @@ gpg: using RSA key > FCF986EA15E6E293A5644F10B4322F04D67658D8 > > > gpg: issuer "ffmpeg-devel@ffmpeg.org" > > > gpg: Good signature from "FFmpeg release signing key & > lt;ffmpeg-devel@ffmpeg.org>" [full]</pre> > > > </li> > > > + <li> > > > + Verify that the release tarball matches the git tag: > (expected differences are missing .git, .gitignore and .gitattributes and > an additional VERSION file) > > > + <pre> > > > + $ diff -ru ffmpeg-5.1.4 gitdir2 > > > +Only in gitdir2/doc/doxy: .gitignore > > > +Only in gitdir2/doc/examples: .gitignore > > > +Only in gitdir2/doc: .gitignore > > > +Only in gitdir2/ffbuild: .gitignore > > > +Only in gitdir2: .git > > > +Only in gitdir2: .gitattributes > > > +Only in gitdir2: .gitignore > > > +Only in gitdir2/libavcodec: .gitignore > > > +Only in gitdir2/libavcodec/tests: .gitignore > > > +Only in gitdir2/libavdevice: .gitignore > > > +Only in gitdir2/libavdevice/tests: .gitignore > > > +Only in gitdir2/libavfilter: .gitignore > > > +Only in gitdir2/libavfilter/opencl: .gitignore > > > +Only in gitdir2/libavfilter/tests: .gitignore > > > +Only in gitdir2/libavformat: .gitignore > > > +Only in gitdir2/libavformat/tests: .gitignore > > > +Only in gitdir2/libavutil: .gitignore > > > +Only in gitdir2/libavutil/tests: .gitignore > > > +Only in gitdir2/libswresample/tests: .gitignore > > > +Only in gitdir2/libswscale/tests: .gitignore > > > +Only in gitdir2/tests/api: .gitignore > > > +Only in gitdir2/tests/checkasm: .gitignore > > > +Only in gitdir2/tests: .gitignore > > > +Only in gitdir2/tools: .gitignore > > > +Only in ffmpeg-5.1.4: VERSION > > > + </pre> > > > + </li> > > > + <li> > > > + Verify that the tag in git is signed > > > > The tags are signed with your key made for this purpose, > > DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one > > listed above. You should include it here the same way, unless the > signature > > yes but before doing that, do you think this is the best place to put all > this? > Putting this on a web host run by people we've never met before is a perfect place to put this information. Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-30 21:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-03-30 14:02 [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball Michael Niedermayer 2024-03-30 14:51 ` James Almer 2024-03-30 17:30 ` Michael Niedermayer 2024-03-30 17:31 ` James Almer 2024-03-30 21:19 ` Michael Niedermayer 2024-03-30 20:30 ` Kieran Kunhya
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git