From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B385148F04 for ; Sat, 30 Mar 2024 17:30:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6DC3768D316; Sat, 30 Mar 2024 19:30:47 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0F2768D282 for ; Sat, 30 Mar 2024 19:30:40 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 49E4A40003 for ; Sat, 30 Mar 2024 17:30:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711819840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g7Rc0tWPy3ZQlts2eBbNwjIet1U2OfRWIr7WFeYy+CU=; b=joL/MaI1wE0PG25v6v2y1hvtAXzQQS3I3y4k+k8WZTA100OimiIIiy5OklaxYkitEissc+ EZVhP+528JLBJ+du4MBEQHdSZG0xUdphsgoD/iV2HBiGvtjC/F787Mh5hUas/lHL3Wj4w4 4dn3CnVlD1I1MuKJqZC80Z7H1IkwcOPDWRD3z+F1xWWQN0uk3BiUQ8wNTBO5Isi8poxE5F ZVrIA6ROYaGGMOwDF54mlNU/904pw2fULaZ1vStnVTDMNjjH8GlP2FP3Ajzs6n4nhRqkVU 9kYd9nSeb3PRi3DfwpsVTGzQiJ8TNeTM+oykuyColv2W2A4YDwxT9vbJd6baDg== Date: Sat, 30 Mar 2024 18:30:39 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240330173039.GW6420@pb2> References: <20240330140225.3395-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] web/download: Extend the verification procedure to check for difference between git and release tarball X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4044015639780310358==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4044015639780310358== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+VgHUvclJ8ZfOlqz" Content-Disposition: inline --+VgHUvclJ8ZfOlqz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 30, 2024 at 11:51:17AM -0300, James Almer wrote: > On 3/30/2024 11:02 AM, Michael Niedermayer wrote: > > Iam not 100% sure this is the best place to put this. But we should som= ewhere > > describe what differences are expected > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > src/download | 34 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > >=20 > > diff --git a/src/download b/src/download > > index 0e6fa7e..34733de 100644 > > --- a/src/download > > +++ b/src/download > > @@ -284,6 +284,40 @@ gpg: using RSA key FCF986EA15E6E293= A5644F10B4322F04D67658D8 > > gpg: issuer "ffmpeg-devel@ffmpeg.org" > > gpg: Good signature from "FFmpeg release signing key <ffmpeg-devel= @ffmpeg.org>" [full] > > > > +
  • > > + Verify that the release tarball matches the git tag: (expected= differences are missing .git, .gitignore and .gitattributes and an additio= nal VERSION file) > > + 
    > > +        $ diff -ru ffmpeg-5.1.4 gitdir2
> > +Only in gitdir2/doc/doxy: .gitignore
> > +Only in gitdir2/doc/examples: .gitignore
> > +Only in gitdir2/doc: .gitignore
> > +Only in gitdir2/ffbuild: .gitignore
> > +Only in gitdir2: .git
> > +Only in gitdir2: .gitattributes
> > +Only in gitdir2: .gitignore
> > +Only in gitdir2/libavcodec: .gitignore
> > +Only in gitdir2/libavcodec/tests: .gitignore
> > +Only in gitdir2/libavdevice: .gitignore
> > +Only in gitdir2/libavdevice/tests: .gitignore
> > +Only in gitdir2/libavfilter: .gitignore
> > +Only in gitdir2/libavfilter/opencl: .gitignore
> > +Only in gitdir2/libavfilter/tests: .gitignore
> > +Only in gitdir2/libavformat: .gitignore
> > +Only in gitdir2/libavformat/tests: .gitignore
> > +Only in gitdir2/libavutil: .gitignore
> > +Only in gitdir2/libavutil/tests: .gitignore
> > +Only in gitdir2/libswresample/tests: .gitignore
> > +Only in gitdir2/libswscale/tests: .gitignore
> > +Only in gitdir2/tests/api: .gitignore
> > +Only in gitdir2/tests/checkasm: .gitignore
> > +Only in gitdir2/tests: .gitignore
> > +Only in gitdir2/tools: .gitignore
> > +Only in ffmpeg-5.1.4: VERSION
> > +
    > > +
    • > > +
  • > > + Verify that the tag in git is signed >=20 > The tags are signed with your key made for this purpose, > DD1EC9E8DE085C629B3E1846B18E8928B3948D64, and not with the tarball one > listed above. You should include it here the same way, unless the signatu= re yes but before doing that, do you think this is the best place to put all t= his? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato=20 --+VgHUvclJ8ZfOlqz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZghMPAAKCRBhHseHBAsP q43vAJ9BDSqKYHsBU+AhA1wWu5RHKJgfqwCePPgpJYGCpNR/gCiFSzppCxF7t5E= =TtVg -----END PGP SIGNATURE----- --+VgHUvclJ8ZfOlqz-- --===============4044015639780310358== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4044015639780310358==--