* [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
@ 2024-03-28 2:07 Xiang, Haihao
2024-04-01 6:10 ` Xiang, Haihao
2024-04-01 20:11 ` Mark Thompson
0 siblings, 2 replies; 6+ messages in thread
From: Xiang, Haihao @ 2024-03-28 2:07 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Haihao Xiang
From: Haihao Xiang <haihao.xiang@intel.com>
Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
instead for decoding. This patch fixes the error below:
[hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
[hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
initialisation returned error.
Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
libavcodec/vaapi_hevc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
index 3bdd2dd1b8..83b94d1a55 100644
--- a/libavcodec/vaapi_hevc.c
+++ b/libavcodec/vaapi_hevc.c
@@ -612,6 +612,13 @@ VAProfile ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n", profile->name);
}
+#if VA_CHECK_VERSION(0, 37, 0)
+ if (!strcmp(profile->name, "Main Intra"))
+ return VAProfileHEVCMain;
+ else if (!strcmp(profile->name, "Main 10 Intra"))
+ return VAProfileHEVCMain10;
+#endif
+
#if VA_CHECK_VERSION(1, 2, 0)
if (!strcmp(profile->name, "Main 12") ||
!strcmp(profile->name, "Main 12 Intra"))
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
2024-03-28 2:07 [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra Xiang, Haihao
@ 2024-04-01 6:10 ` Xiang, Haihao
2024-04-01 20:11 ` Mark Thompson
1 sibling, 0 replies; 6+ messages in thread
From: Xiang, Haihao @ 2024-04-01 6:10 UTC (permalink / raw)
To: ffmpeg-devel
On Do, 2024-03-28 at 10:07 +0800, Xiang, Haihao wrote:
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
> instead for decoding. This patch fixes the error below:
>
> [hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
> [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
> initialisation returned error.
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
> libavcodec/vaapi_hevc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
> index 3bdd2dd1b8..83b94d1a55 100644
> --- a/libavcodec/vaapi_hevc.c
> +++ b/libavcodec/vaapi_hevc.c
> @@ -612,6 +612,13 @@ VAProfile
> ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
> av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n", profile-
> >name);
> }
>
> +#if VA_CHECK_VERSION(0, 37, 0)
> + if (!strcmp(profile->name, "Main Intra"))
> + return VAProfileHEVCMain;
> + else if (!strcmp(profile->name, "Main 10 Intra"))
> + return VAProfileHEVCMain10;
> +#endif
> +
> #if VA_CHECK_VERSION(1, 2, 0)
> if (!strcmp(profile->name, "Main 12") ||
> !strcmp(profile->name, "Main 12 Intra"))
Will apply,
- Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
2024-03-28 2:07 [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra Xiang, Haihao
2024-04-01 6:10 ` Xiang, Haihao
@ 2024-04-01 20:11 ` Mark Thompson
2024-04-02 6:55 ` Xiang, Haihao
1 sibling, 1 reply; 6+ messages in thread
From: Mark Thompson @ 2024-04-01 20:11 UTC (permalink / raw)
To: ffmpeg-devel
On 28/03/2024 02:07, Xiang, Haihao wrote:
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
> instead for decoding. This patch fixes the error below:
>
> [hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
> [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
> initialisation returned error.
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
> libavcodec/vaapi_hevc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
> index 3bdd2dd1b8..83b94d1a55 100644
> --- a/libavcodec/vaapi_hevc.c
> +++ b/libavcodec/vaapi_hevc.c
> @@ -612,6 +612,13 @@ VAProfile ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
> av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n", profile->name);
> }
>
> +#if VA_CHECK_VERSION(0, 37, 0)
> + if (!strcmp(profile->name, "Main Intra"))
> + return VAProfileHEVCMain;
> + else if (!strcmp(profile->name, "Main 10 Intra"))
> + return VAProfileHEVCMain10;
> +#endif
> +
> #if VA_CHECK_VERSION(1, 2, 0)
> if (!strcmp(profile->name, "Main 12") ||
> !strcmp(profile->name, "Main 12 Intra"))
What if high_precision_offsets_enabled_flag is set?
(That doesn't matter for the VAAPI encoder setting the profile because we always have it as zero.)
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
2024-04-01 20:11 ` Mark Thompson
@ 2024-04-02 6:55 ` Xiang, Haihao
2024-04-02 21:01 ` Mark Thompson
0 siblings, 1 reply; 6+ messages in thread
From: Xiang, Haihao @ 2024-04-02 6:55 UTC (permalink / raw)
To: ffmpeg-devel
On Ma, 2024-04-01 at 21:11 +0100, Mark Thompson wrote:
> On 28/03/2024 02:07, Xiang, Haihao wrote:
> > From: Haihao Xiang <haihao.xiang@intel.com>
> >
> > Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
> > instead for decoding. This patch fixes the error below:
> >
> > [hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
> > [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
> > initialisation returned error.
> >
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> > libavcodec/vaapi_hevc.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
> > index 3bdd2dd1b8..83b94d1a55 100644
> > --- a/libavcodec/vaapi_hevc.c
> > +++ b/libavcodec/vaapi_hevc.c
> > @@ -612,6 +612,13 @@ VAProfile
> > ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
> > av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n",
> > profile->name);
> > }
> >
> > +#if VA_CHECK_VERSION(0, 37, 0)
> > + if (!strcmp(profile->name, "Main Intra"))
> > + return VAProfileHEVCMain;
> > + else if (!strcmp(profile->name, "Main 10 Intra"))
> > + return VAProfileHEVCMain10;
> > +#endif
> > +
> > #if VA_CHECK_VERSION(1, 2, 0)
> > if (!strcmp(profile->name, "Main 12") ||
> > !strcmp(profile->name, "Main 12 Intra"))
>
> What if high_precision_offsets_enabled_flag is set?
>
> (That doesn't matter for the VAAPI encoder setting the profile because we
> always have it as zero.)
Here use VAProfileHEVCMain or VAProfileHEVCMain10 to create VAConfig for
decoding, avctx->profile (4) is not changed.
high_precision_offsets_enabled_flag is set in VAPictureParameterBufferHEVCRext
when avctx->profile is 4.
BRs
Haihao
>
> Thanks,
>
> - Mark
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
2024-04-02 6:55 ` Xiang, Haihao
@ 2024-04-02 21:01 ` Mark Thompson
2024-04-03 1:26 ` Xiang, Haihao
0 siblings, 1 reply; 6+ messages in thread
From: Mark Thompson @ 2024-04-02 21:01 UTC (permalink / raw)
To: ffmpeg-devel
On 02/04/2024 07:55, Xiang, Haihao wrote:
> On Ma, 2024-04-01 at 21:11 +0100, Mark Thompson wrote:
>> On 28/03/2024 02:07, Xiang, Haihao wrote:
>>> From: Haihao Xiang <haihao.xiang@intel.com>
>>>
>>> Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
>>> instead for decoding. This patch fixes the error below:
>>>
>>> [hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
>>> [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
>>> initialisation returned error.
>>>
>>> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
>>> ---
>>> libavcodec/vaapi_hevc.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
>>> index 3bdd2dd1b8..83b94d1a55 100644
>>> --- a/libavcodec/vaapi_hevc.c
>>> +++ b/libavcodec/vaapi_hevc.c
>>> @@ -612,6 +612,13 @@ VAProfile
>>> ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
>>> av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n",
>>> profile->name);
>>> }
>>>
>>> +#if VA_CHECK_VERSION(0, 37, 0)
>>> + if (!strcmp(profile->name, "Main Intra"))
>>> + return VAProfileHEVCMain;
>>> + else if (!strcmp(profile->name, "Main 10 Intra"))
>>> + return VAProfileHEVCMain10;
>>> +#endif
>>> +
>>> #if VA_CHECK_VERSION(1, 2, 0)
>>> if (!strcmp(profile->name, "Main 12") ||
>>> !strcmp(profile->name, "Main 12 Intra"))
>>
>> What if high_precision_offsets_enabled_flag is set?
>>
>> (That doesn't matter for the VAAPI encoder setting the profile because we
>> always have it as zero.)
>
> Here use VAProfileHEVCMain or VAProfileHEVCMain10 to create VAConfig for
> decoding, avctx->profile (4) is not changed.
> high_precision_offsets_enabled_flag is set in VAPictureParameterBufferHEVCRext
> when avctx->profile is 4.
But Main and Main 10 profile have:
"Active SPSs for the base layer shall have ... high_precision_offsets_enabled_flag, ... when present, equal to 0 only."
so a decoder implementing those profiles need not support it. (It may work as a compatible extension as the field is there, but if it doesn't also support general rext cases then this is unlikely to be implemented.)
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra
2024-04-02 21:01 ` Mark Thompson
@ 2024-04-03 1:26 ` Xiang, Haihao
0 siblings, 0 replies; 6+ messages in thread
From: Xiang, Haihao @ 2024-04-03 1:26 UTC (permalink / raw)
To: ffmpeg-devel
On Di, 2024-04-02 at 22:01 +0100, Mark Thompson wrote:
> On 02/04/2024 07:55, Xiang, Haihao wrote:
> > On Ma, 2024-04-01 at 21:11 +0100, Mark Thompson wrote:
> > > On 28/03/2024 02:07, Xiang, Haihao wrote:
> > > > From: Haihao Xiang <haihao.xiang@intel.com>
> > > >
> > > > Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10
> > > > instead for decoding. This patch fixes the error below:
> > > >
> > > > [hevc @ 0x55a771b80a00] No support for codec hevc profile 4.
> > > > [hevc @ 0x55a771b80a00] Failed setup for format vaapi: hwaccel
> > > > initialisation returned error.
> > > >
> > > > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > > > ---
> > > > libavcodec/vaapi_hevc.c | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c
> > > > index 3bdd2dd1b8..83b94d1a55 100644
> > > > --- a/libavcodec/vaapi_hevc.c
> > > > +++ b/libavcodec/vaapi_hevc.c
> > > > @@ -612,6 +612,13 @@ VAProfile
> > > > ff_vaapi_parse_hevc_rext_scc_profile(AVCodecContext *avctx)
> > > > av_log(avctx, AV_LOG_VERBOSE, "HEVC profile %s is found.\n",
> > > > profile->name);
> > > > }
> > > >
> > > > +#if VA_CHECK_VERSION(0, 37, 0)
> > > > + if (!strcmp(profile->name, "Main Intra"))
> > > > + return VAProfileHEVCMain;
> > > > + else if (!strcmp(profile->name, "Main 10 Intra"))
> > > > + return VAProfileHEVCMain10;
> > > > +#endif
> > > > +
> > > > #if VA_CHECK_VERSION(1, 2, 0)
> > > > if (!strcmp(profile->name, "Main 12") ||
> > > > !strcmp(profile->name, "Main 12 Intra"))
> > >
> > > What if high_precision_offsets_enabled_flag is set?
> > >
> > > (That doesn't matter for the VAAPI encoder setting the profile because we
> > > always have it as zero.)
> >
> > Here use VAProfileHEVCMain or VAProfileHEVCMain10 to create VAConfig for
> > decoding, avctx->profile (4) is not changed.
> > high_precision_offsets_enabled_flag is set in
> > VAPictureParameterBufferHEVCRext
> > when avctx->profile is 4.
>
> But Main and Main 10 profile have:
>
> "Active SPSs for the base layer shall have ...
> high_precision_offsets_enabled_flag, ... when present, equal to 0 only."
>
> so a decoder implementing those profiles need not support it. (It may work as
> a compatible extension as the field is there, but if it doesn't also support
> general rext cases then this is unlikely to be implemented.)
>
I get your point, the underlying driver mightn't support
VAPictureParameterBufferHEVCRext. Seems we should add new profiles in libva.
Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-03 1:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 2:07 [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra Xiang, Haihao
2024-04-01 6:10 ` Xiang, Haihao
2024-04-01 20:11 ` Mark Thompson
2024-04-02 6:55 ` Xiang, Haihao
2024-04-02 21:01 ` Mark Thompson
2024-04-03 1:26 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git