From: arch1t3cht <arch1t3cht@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: arch1t3cht <arch1t3cht@gmail.com> Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/h264dec: Properly mark frames as recovered when draining Date: Thu, 28 Mar 2024 02:56:37 +0100 Message-ID: <20240328015639.1425494-2-arch1t3cht@gmail.com> (raw) In-Reply-To: <20240328015639.1425494-1-arch1t3cht@gmail.com> When decoding starts at a SEI recovery point very shortly before the end of the video stream, there can be frames which are decoded before the recovery point's frame is output and which will only be output once the draining has started. Previously, these frames would never be set as recovered. This commit copies the logic from h264_select_output_frame to send_next_delayed_frame to properly mark such frames as recovered. Fixes ticket #10936. Signed-off-by: arch1t3cht <arch1t3cht@gmail.com> --- libavcodec/h264dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index b4973fce29..8503ea018a 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -1013,6 +1013,9 @@ static int send_next_delayed_frame(H264Context *h, AVFrame *dst_frame, h->delayed_pic[i] = h->delayed_pic[i + 1]; if (out) { + h->frame_recovered |= out->recovered; + out->recovered |= h->frame_recovered & FRAME_RECOVERED_SEI; + out->reference &= ~DELAYED_PIC_REF; ret = finalize_frame(h, dst_frame, out, got_frame); if (ret < 0) -- 2.44.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-28 0:57 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-28 1:56 [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames " arch1t3cht 2024-03-28 1:56 ` arch1t3cht [this message] 2024-03-28 1:56 ` [FFmpeg-devel] [PATCH 2/3] avcodec/h264dec: Handle non-recovered " arch1t3cht 2024-03-28 1:56 ` [FFmpeg-devel] [PATCH 3/3] avcodec/h264dec: Reindent after the previous commit arch1t3cht 2024-04-03 21:45 ` [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining arch1t3cht 2024-04-09 15:15 ` Derek Buitenhuis 2024-04-15 18:16 ` Derek Buitenhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240328015639.1425494-2-arch1t3cht@gmail.com \ --to=arch1t3cht@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git