From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8F6349A67 for ; Wed, 27 Mar 2024 23:27:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D31F368D51C; Thu, 28 Mar 2024 01:27:10 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AF3168BE7C for ; Thu, 28 Mar 2024 01:27:03 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 19CFB240003 for ; Wed, 27 Mar 2024 23:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1711582023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3mHHQBmW201HkftHLR94T7UMvY61gW9jIVqNZ6ucIY=; b=Fv2wHTQHtZK1lzAh6/9gMOGaTCYibXLfNDwt9RrKS5NMfj3satuOq3gWOlepWyYSKy6H/1 7ZSVOz8gD9CWiSTmE1MYJMEMwB9KbV601gpmwpuhtCWv+GrcgOobUjzw2P8JfOelMrzGHS NJnXcQWhBppsLNoqfe+qYVhX7SO81tjgA5vQb7Y2MDvhSL2xiZyinCUNPk3GnJ2l0GpTM0 TuUcxEGdZGknn0RvDLXEI5c8asCv2L5ffe+cK4RO/LztxLlRGmITBWUd3nKi5EQQEQNVg6 BJVJpyBA1Z2ScyL0V5hPZHV9SUDhpi3dVR1FP3bqKfwdQ/kKZOOlB4IgV7uVvA== Date: Thu, 28 Mar 2024 00:27:02 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240327232702.GM6420@pb2> References: <20240322230818.18997-1-michael@niedermayer.cc> <171152515798.7287.8979021106267679923@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <171152515798.7287.8979021106267679923@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7335963464538111264==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7335963464538111264== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eavn445ubYuEWVZQ" Content-Disposition: inline --eavn445ubYuEWVZQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2024 at 08:39:17AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-23 00:08:16) > > Fixes: Timeout > > Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-57911= 44363491328 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/cafdec.c | 5 +++++ > > 1 file changed, 5 insertions(+) > >=20 > > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c > > index 426c56b9bd..334077efb5 100644 > > --- a/libavformat/cafdec.c > > +++ b/libavformat/cafdec.c > > @@ -33,6 +33,7 @@ > > #include "isom.h" > > #include "mov_chan.h" > > #include "libavcodec/flac.h" > > +#include "libavcodec/internal.h" > > #include "libavutil/intreadwrite.h" > > #include "libavutil/intfloat.h" > > #include "libavutil/dict.h" > > @@ -87,6 +88,10 @@ static int read_desc_chunk(AVFormatContext *s) > > st->codecpar->ch_layout.nb_channels =3D avio_rb32(pb); > > st->codecpar->bits_per_coded_sample =3D avio_rb32(pb); > > =20 > > + if (st->codecpar->ch_layout.nb_channels > FF_SANE_NB_CHANNELS || >=20 > I dislike this. I dislike it too thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle --eavn445ubYuEWVZQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgSrPAAKCRBhHseHBAsP q988AJ0RPsWI/6USrKo2Y/lT2giD0qMlmwCfTgR1abZ/mZqCJcmel2LyJA20mzI= =Whar -----END PGP SIGNATURE----- --eavn445ubYuEWVZQ-- --===============7335963464538111264== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7335963464538111264==--