From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 55EF74A401
	for <ffmpegdev@gitmailbox.com>; Wed, 27 Mar 2024 17:49:56 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FB8F68D461;
	Wed, 27 Mar 2024 19:49:54 +0200 (EET)
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
 [217.70.183.195])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5401468D2C7
 for <ffmpeg-devel@ffmpeg.org>; Wed, 27 Mar 2024 19:49:47 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 8F97260002
 for <ffmpeg-devel@ffmpeg.org>; Wed, 27 Mar 2024 17:49:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1711561786;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=uU3Tc03cEUwP/rQRDzbSkVccWkJb1yJoK5XcFDLJTo0=;
 b=lZeYCcWZVPCMFEG9ILviIq9mCah0xH8wj7zwn1234hGx09EptgjuQW4z9lhlDGPm9J3GfD
 TqPqbZJtAfxwCp4t2aOSaVo9gXrfggoDtQcMCJ6S2mIy71sdAqL5EEZy8q6rdqEfwN6gqH
 VOwijpQHJRa8SC0sbyWZ3BVfWmQt4Y2TmWjBMM0iOL8jUSFS8ERJanf6PDov4a7q3vgJHy
 srITNp/ZgJP2SAzt2G44ybmzHa3Fhwrpn8AwNWFnD1C/2uaw/CUzFOrJtjocOIcXah0vS4
 hBs56/43gQbN7y1x7IfYJaKhPZLNnU9JmmOKh1mcrLh1XOxWA6oD1DoICEVf8w==
Date: Wed, 27 Mar 2024 18:49:42 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Message-ID: <20240327174942.GE2460414@pb2>
References: <20231212074119.EC15B41151B@natalya.videolan.org>
MIME-Version: 1.0
In-Reply-To: <20231212074119.EC15B41151B@natalya.videolan.org>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: convert to a
 threaded architecture
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============2787369890217625518=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20240327174942.GE2460414@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============2787369890217625518==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="QNDPHrPUIc00TOLW"
Content-Disposition: inline


--QNDPHrPUIc00TOLW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 12, 2023 at 07:41:18AM +0000, Anton Khirnov wrote:
> ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Tue Jul 18 =
16:37:52 2023 +0200| [d119ae2fd82a494d9430ff4d4fc262961a68c598] | committer=
: Anton Khirnov
>=20
> fftools/ffmpeg: convert to a threaded architecture
>=20
> Change the main loop and every component (demuxers, decoders, filters,
> encoders, muxers) to use the previously added transcode scheduler. Every
> instance of every such component was already running in a separate
> thread, but now they can actually run in parallel.
>=20
> Changes the results of ffmpeg-fix_sub_duration_heartbeat - tested by
> JEEB to be more correct and deterministic.
>=20
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3Dd119ae2fd=
82a494d9430ff4d4fc262961a68c598
> ---
>=20
>  Changelog                                        |   2 +
>  fftools/ffmpeg.c                                 | 374 +-----------
>  fftools/ffmpeg.h                                 |  97 +--
>  fftools/ffmpeg_dec.c                             | 313 +++-------
>  fftools/ffmpeg_demux.c                           | 268 ++++-----
>  fftools/ffmpeg_enc.c                             | 377 ++----------
>  fftools/ffmpeg_filter.c                          | 714 ++++++-----------=
------
>  fftools/ffmpeg_mux.c                             | 324 ++--------
>  fftools/ffmpeg_mux.h                             |  24 +-
>  fftools/ffmpeg_mux_init.c                        |  88 +--
>  fftools/ffmpeg_opt.c                             |   6 +-
>  tests/ref/fate/ffmpeg-fix_sub_duration_heartbeat |  34 +-
>  12 files changed, 600 insertions(+), 2021 deletions(-)

breaks: (races, violates bitexact)

for i in `seq 50` ; do ./ffmpeg -v 0 -i ~/tickets/4003/mp3_demuxer_EOI.mp3 =
-bitexact -vframes 1 -y /tmp/file-4003.avi ; md5sum /tmp/file-4003.avi

before:
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi


aftre:
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
db7ad90e0e02af90e98e09c9b0158124  /tmp/file-4003.avi
933c2cc12cda1deac7245ec768f5b35f  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi
1508e16c1877abe172173cd1e11f1155  /tmp/file-4003.avi


should i open a ticket to track this or someone has time
to look into this ?

thx

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire

--QNDPHrPUIc00TOLW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZgRcMwAKCRBhHseHBAsP
q6spAKCSvg2dfelqiFqZ6cWWf9qGnZQzlACgjTTPX3CgvKqgKN+9Hy7Ut5v8NK0=
=US+0
-----END PGP SIGNATURE-----

--QNDPHrPUIc00TOLW--

--===============2787369890217625518==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============2787369890217625518==--